Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/objects.cc

Issue 11348222: Make indexed intercepted methods enumerable by default. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3379 matching lines...) Expand 10 before | Expand all | Expand 10 after
3390 v8::IndexedPropertyGetter getter = 3390 v8::IndexedPropertyGetter getter =
3391 v8::ToCData<v8::IndexedPropertyGetter>(interceptor->getter()); 3391 v8::ToCData<v8::IndexedPropertyGetter>(interceptor->getter());
3392 LOG(isolate, 3392 LOG(isolate,
3393 ApiIndexedPropertyAccess("interceptor-indexed-get-has", this, index)); 3393 ApiIndexedPropertyAccess("interceptor-indexed-get-has", this, index));
3394 v8::Handle<v8::Value> result; 3394 v8::Handle<v8::Value> result;
3395 { 3395 {
3396 // Leaving JavaScript. 3396 // Leaving JavaScript.
3397 VMState state(isolate, EXTERNAL); 3397 VMState state(isolate, EXTERNAL);
3398 result = getter(index, info); 3398 result = getter(index, info);
3399 } 3399 }
3400 if (!result.IsEmpty()) return DONT_ENUM; 3400 if (!result.IsEmpty()) return NONE;
3401 } 3401 }
3402 3402
3403 return holder->GetElementAttributeWithoutInterceptor( 3403 return holder->GetElementAttributeWithoutInterceptor(
3404 *hreceiver, index, continue_search); 3404 *hreceiver, index, continue_search);
3405 } 3405 }
3406 3406
3407 3407
3408 PropertyAttributes JSObject::GetElementAttributeWithoutInterceptor( 3408 PropertyAttributes JSObject::GetElementAttributeWithoutInterceptor(
3409 JSReceiver* receiver, uint32_t index, bool continue_search) { 3409 JSReceiver* receiver, uint32_t index, bool continue_search) {
3410 Isolate* isolate = GetIsolate(); 3410 Isolate* isolate = GetIsolate();
(...skipping 10474 matching lines...) Expand 10 before | Expand all | Expand 10 after
13885 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 13885 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
13886 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 13886 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
13887 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 13887 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
13888 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 13888 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
13889 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 13889 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
13890 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 13890 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
13891 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 13891 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
13892 } 13892 }
13893 13893
13894 } } // namespace v8::internal 13894 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698