tools/telemetry/telemetry/adb_commands.py - Issue 11348217: [telemetry] Removing flake in wpr_server.py caused by static port assignment from chrome/test/funct…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/adb_commands.py

Issue 11348217: [telemetry] Removing flake in wpr_server.py caused by static port assignment from chrome/test/funct… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move away from pylib Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/adb_commands.py

diff --git a/tools/telemetry/telemetry/adb_commands.py b/tools/telemetry/telemetry/adb_commands.py

index 6836689c334285522f4531dcde49c3d2c058ae09..3626c8fd9f535d0a1da4ed1699464eacbaf8c7e5 100644

--- a/tools/telemetry/telemetry/adb_commands.py

+++ b/tools/telemetry/telemetry/adb_commands.py

@@ -160,12 +160,8 @@ class Forwarder(object):

tool = valgrind_tools.BaseTool()

self._host_port = port_pairs[0].local_port

- new_port_pairs = []

- for port_pair in port_pairs:

- if port_pair.remote_port is None:

- new_port_pairs.append((port_pair.local_port, port_pair.local_port))

- else:

- new_port_pairs.append((port_pair.local_port, port_pair.remote_port))

+ new_port_pairs = [(port_pair.local_port, port_pair.remote_port)

+ for port_pair in port_pairs]

buildtype = 'Debug'

if HasForwarder('Release'):

« no previous file with comments | « no previous file | tools/telemetry/telemetry/android_browser_backend.py » ('j') | no next file with comments »