Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: tools/telemetry/telemetry/adb_commands.py

Issue 11348217: [telemetry] Removing flake in wpr_server.py caused by static port assignment from chrome/test/funct… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/adb_commands.py
diff --git a/tools/telemetry/telemetry/adb_commands.py b/tools/telemetry/telemetry/adb_commands.py
index d122aa5dc7bfafb0fe096f4415fd849d9f0d06ae..e410f060b78d11a189a3572ae317804eddce86c8 100644
--- a/tools/telemetry/telemetry/adb_commands.py
+++ b/tools/telemetry/telemetry/adb_commands.py
@@ -133,11 +133,13 @@ class Forwarder(object):
def __init__(self, adb, *port_pairs):
assert HasForwarder()
tool = valgrind_tools.BaseTool()
- self._host_port = port_pairs[0][0]
+ self._host_port = port_pairs[0][0] or port_pairs[0][1]
new_port_pairs = []
for port_pair in port_pairs:
- if port_pair[1] is None:
+ if port_pair[0] is None:
+ new_port_pairs.append((port_pair[1], port_pair[1]))
+ elif port_pair[1] is None:
new_port_pairs.append((port_pair[0], port_pair[0]))
else:
new_port_pairs.append(port_pair)

Powered by Google App Engine
This is Rietveld 408576698