[telemetry] Removing flake in wpr_server.py caused by static port assignment from chrome/test/funct…

chrome/test/functional/webpagereplay.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Start and stop Web Page Replay.
 
 Of the public module names, the following ones are key:
   CHROME_FLAGS: Chrome options to make it work with Web Page Replay.
   ReplayServer: a class to start/stop Web Page Replay.
 """
 
 import logging
 import os
 import signal
+import socket
 import subprocess
 import sys
 import time
 import urllib
 
+def GetRandomOpenPort():

[bulach, 2012/11/26 13:53:46]

drive-by: can we re-use / improve this?
http://src.chromium.org/viewvc/chrome/trunk/src/build/android/pylib/ports.py?...

it has a nicer interface to detect whether or not the port is in use, and keep
track of them..

+  tmp = socket.socket()
+  tmp.bind(('', 0))
+  port = tmp.getsockname()[1]
+  tmp.close()
 
-HTTP_PORT = 8080
-HTTPS_PORT = 8413
+  return port
+
+HTTP_PORT = GetRandomOpenPort()
+HTTPS_PORT = GetRandomOpenPort()
 REPLAY_HOST='127.0.0.1'
 CHROME_FLAGS = [
     '--host-resolver-rules=MAP * %s,EXCLUDE localhost' % REPLAY_HOST,
     '--testing-fixed-http-port=%s' % HTTP_PORT,
     '--testing-fixed-https-port=%s' % HTTPS_PORT,
     '--ignore-certificate-errors',
     ]
 
 _CHROME_BASE_DIR = os.path.abspath(os.path.join(
     os.path.dirname(__file__), os.pardir, os.pardir, os.pardir, os.pardir))
@@ skipping 138 matching lines @@
       self.log_fh.close()
 
   def __enter__(self):
     """Add support for with-statement."""
     self.StartServer()
     return self
 
   def __exit__(self, unused_exc_type, unused_exc_val, unused_exc_tb):
     """Add support for with-statement."""
     self.StopServer()