Align panel icons on the right / end.

ash/launcher/launcher_view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/launcher/launcher_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "ash/launcher/launcher.h"
@@ skipping 202 matching lines @@
     model_->Add(item);
     return id;
   }
 
   LauncherID AddTabbedBrowser() {
     LauncherID id = AddTabbedBrowserNoWait();
     test_api_->RunMessageLoopUntilAnimationsDone();
     return id;
   }
 
+  LauncherID AddPanel() {
+    LauncherID id = AddPanelNoWait();
+    test_api_->RunMessageLoopUntilAnimationsDone();
+    return id;
+  }
+
   LauncherID AddPlatformAppNoWait() {
     LauncherItem item;
     item.type = TYPE_PLATFORM_APP;
     item.status = STATUS_RUNNING;
 
     LauncherID id = model_->next_id();
     model_->Add(item);
     return id;
   }
 
+  LauncherID AddPanelNoWait() {
+    LauncherItem item;
+    item.type = TYPE_APP_PANEL;
+    item.status = STATUS_RUNNING;
+
+    LauncherID id = model_->next_id();
+    model_->Add(item);
+    return id;
+  }
+
   LauncherID AddPlatformApp() {
     LauncherID id = AddPlatformAppNoWait();
     test_api_->RunMessageLoopUntilAnimationsDone();
     return id;
   }
 
   void RemoveByID(LauncherID id) {
     model_->RemoveItemAt(model_->ItemIndexByID(id));
     test_api_->RunMessageLoopUntilAnimationsDone();
   }
@@ skipping 120 matching lines @@
 
     last_added = AddAppShortcut();
   }
 
   // The last added app short button should be visible.
   EXPECT_TRUE(GetButtonByID(last_added)->visible());
   // And the browser button is invisible.
   EXPECT_FALSE(GetButtonByID(browser_button_id)->visible());
 }
 
+TEST_F(LauncherViewTest, AddPanelHidesTabbedBrowser) {
+  ASSERT_EQ(test_api_->GetLastVisibleIndex() + 1,
+            test_api_->GetButtonCount());
+
+  // Add tabbed browser until overflow, remember last visible tabbed browser.
+  LauncherID first_added = AddTabbedBrowser();
+  EXPECT_TRUE(GetButtonByID(first_added)->visible());
+  LauncherID last_visible = first_added;
+  while (true) {
+    LauncherID added = AddTabbedBrowser();
+    if (test_api_->IsOverflowButtonVisible()) {
+      EXPECT_FALSE(GetButtonByID(added)->visible());
+      break;
+    }
+    last_visible = added;

[stevenjb, 2012/11/26 18:19:21]

We should add something like:
++items_added;
ASSERT_LT(10000, items_added);

To avoid relying on a timeout should the test fail.

[flackr, 2012/11/27 18:40:21]

Done. And the other instances of this in the file.

+  }
+
+  LauncherID panel = AddPanel();
+  EXPECT_TRUE(GetButtonByID(panel)->visible());
+  EXPECT_FALSE(GetButtonByID(last_visible)->visible());
+
+  RemoveByID(panel);
+  EXPECT_TRUE(GetButtonByID(last_visible)->visible());
+}
+
+TEST_F(LauncherViewTest, PanelsHideLast) {
+  ASSERT_EQ(test_api_->GetLastVisibleIndex() + 1,
+            test_api_->GetButtonCount());
+
+  // Add tabbed browser.
+  LauncherID browser = AddTabbedBrowser();
+  LauncherID first_panel = AddPanel();
+
+  EXPECT_TRUE(GetButtonByID(browser)->visible());
+  EXPECT_TRUE(GetButtonByID(first_panel)->visible());
+
+  LauncherID last_panel = first_panel;
+  while (!test_api_->IsOverflowButtonVisible())
+    last_panel = AddPanel();

[stevenjb, 2012/11/26 18:19:21]

Same here.

[flackr, 2012/11/27 18:40:21]

Done.

+
+  EXPECT_TRUE(GetButtonByID(last_panel)->visible());
+  EXPECT_TRUE(GetButtonByID(first_panel)->visible());
+  EXPECT_FALSE(GetButtonByID(browser)->visible());
+}
+
 // Adds button until overflow then removes first added one. Verifies that
 // the last added one changes from invisible to visible and overflow
 // chevron is gone.
 TEST_F(LauncherViewTest, RemoveButtonRevealsOverflowed) {
   // All buttons should be visible.
   ASSERT_EQ(test_api_->GetLastVisibleIndex() + 1,
             test_api_->GetButtonCount());
 
   // Add tabbed browser until overflow.
-  LauncherID first_added= AddTabbedBrowser();
+  LauncherID first_added = AddTabbedBrowser();
   LauncherID last_added = first_added;
   while (!test_api_->IsOverflowButtonVisible())
     last_added = AddTabbedBrowser();
 
   // Expect add more than 1 button. First added is visible and last is not.
   EXPECT_NE(first_added, last_added);
   EXPECT_TRUE(GetButtonByID(first_added)->visible());
   EXPECT_FALSE(GetButtonByID(last_added)->visible());
 
   // Remove first added.
@@ skipping 328 matching lines @@
   const int app_list_button_index = test_api_->GetButtonCount() - 1;
   const gfx::Rect& app_list_ideal_bounds =
       test_api_->GetIdealBoundsByIndex(app_list_button_index);
   const gfx::Rect& app_list_bounds =
       test_api_->GetBoundsByIndex(app_list_button_index);
   EXPECT_EQ(app_list_bounds, app_list_ideal_bounds);
 }
 
 }  // namespace test
 }  // namespace ash