Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: content/browser/android/media_player_manager_android.cc

Issue 11348199: Free (and pause) audio resources when getting a phone call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@input_color
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/media_player_manager_android.cc
diff --git a/content/browser/android/media_player_manager_android.cc b/content/browser/android/media_player_manager_android.cc
index 2716079527d87d29b038f0b989d201ddebb68a88..6f0c6687fedd0c621cef1b57cde9aba50758aa97 100644
--- a/content/browser/android/media_player_manager_android.cc
+++ b/content/browser/android/media_player_manager_android.cc
@@ -123,6 +123,8 @@ void MediaPlayerManagerAndroid::OnInitialize(
base::Bind(&MediaPlayerManagerAndroid::OnSeekComplete,
base::Unretained(this)),
base::Bind(&MediaPlayerManagerAndroid::OnTimeUpdate,
+ base::Unretained(this)),
+ base::Bind(&MediaPlayerManagerAndroid::OnMediaInterrupted,
base::Unretained(this))));
// Send a MediaPrepared message to webkit so that Load() can finish.
@@ -220,6 +222,10 @@ void MediaPlayerManagerAndroid::OnPlaybackComplete(int player_id) {
video_view_.OnPlaybackComplete();
}
+void MediaPlayerManagerAndroid::OnMediaInterrupted(int player_id) {
+ OnReleaseResources(player_id);
qinmin 2012/11/23 23:46:38 This will cause some problems on the webkit side m
Miguel Garcia 2012/11/26 10:37:51 Wow thanks a lot for catching this! I added the ch
+}
+
void MediaPlayerManagerAndroid::OnBufferingUpdate(
int player_id, int percentage) {
Send(new MediaPlayerMsg_MediaBufferingUpdate(

Powered by Google App Engine
This is Rietveld 408576698