Issue 11348195: PredictableCodeSizeScope checks the expected size now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348195: PredictableCodeSizeScope checks the expected size now. (Closed)

Created:
8 years, 1 month ago by Sven Panne

Modified:
8 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

PredictableCodeSizeScope checks the expected size now. We still have some problems on ARM, so the size check currently optional. Furthermore, we don't use PredictableCodeSizeScope at all place where we should do it. Both issues are cleaned up in upcoming CLs. Committed: https://code.google.com/p/v8/source/detail?r=13037

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -16 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/assembler.h	View	1 chunk	+4 lines, -9 lines	0 comments	Download
M	src/assembler.cc	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages