Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 11348176: Add dehoisting to the string printout of hydrogen and lithium instructions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Whitespace issues found by presubmit. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1996 matching lines...) Expand 10 before | Expand all | Expand 10 after
2007 } else { 2007 } else {
2008 ASSERT(elements_kind() >= FIRST_EXTERNAL_ARRAY_ELEMENTS_KIND && 2008 ASSERT(elements_kind() >= FIRST_EXTERNAL_ARRAY_ELEMENTS_KIND &&
2009 elements_kind() <= LAST_EXTERNAL_ARRAY_ELEMENTS_KIND); 2009 elements_kind() <= LAST_EXTERNAL_ARRAY_ELEMENTS_KIND);
2010 elements()->PrintNameTo(stream); 2010 elements()->PrintNameTo(stream);
2011 stream->Add("."); 2011 stream->Add(".");
2012 stream->Add(ElementsKindToString(elements_kind())); 2012 stream->Add(ElementsKindToString(elements_kind()));
2013 } 2013 }
2014 2014
2015 stream->Add("["); 2015 stream->Add("[");
2016 key()->PrintNameTo(stream); 2016 key()->PrintNameTo(stream);
2017 stream->Add("] "); 2017 if (IsDehoisted()) {
2018 stream->Add(" + %d] ", index_offset());
2019 } else {
2020 stream->Add("] ");
2021 }
2022
2018 dependency()->PrintNameTo(stream); 2023 dependency()->PrintNameTo(stream);
2019 if (RequiresHoleCheck()) { 2024 if (RequiresHoleCheck()) {
2020 stream->Add(" check_hole"); 2025 stream->Add(" check_hole");
2021 } 2026 }
2022 } 2027 }
2023 2028
2024 2029
2025 bool HLoadKeyed::RequiresHoleCheck() const { 2030 bool HLoadKeyed::RequiresHoleCheck() const {
2026 if (IsFastPackedElementsKind(elements_kind())) { 2031 if (IsFastPackedElementsKind(elements_kind())) {
2027 return false; 2032 return false;
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
2116 } else { 2121 } else {
2117 elements()->PrintNameTo(stream); 2122 elements()->PrintNameTo(stream);
2118 stream->Add("."); 2123 stream->Add(".");
2119 stream->Add(ElementsKindToString(elements_kind())); 2124 stream->Add(ElementsKindToString(elements_kind()));
2120 ASSERT(elements_kind() >= FIRST_EXTERNAL_ARRAY_ELEMENTS_KIND && 2125 ASSERT(elements_kind() >= FIRST_EXTERNAL_ARRAY_ELEMENTS_KIND &&
2121 elements_kind() <= LAST_EXTERNAL_ARRAY_ELEMENTS_KIND); 2126 elements_kind() <= LAST_EXTERNAL_ARRAY_ELEMENTS_KIND);
2122 } 2127 }
2123 2128
2124 stream->Add("["); 2129 stream->Add("[");
2125 key()->PrintNameTo(stream); 2130 key()->PrintNameTo(stream);
2126 stream->Add("] = "); 2131 if (IsDehoisted()) {
2132 stream->Add(" + %d] = ", index_offset());
2133 } else {
2134 stream->Add("] = ");
2135 }
2136
2127 value()->PrintNameTo(stream); 2137 value()->PrintNameTo(stream);
2128 } 2138 }
2129 2139
2130 2140
2131 void HStoreKeyedGeneric::PrintDataTo(StringStream* stream) { 2141 void HStoreKeyedGeneric::PrintDataTo(StringStream* stream) {
2132 object()->PrintNameTo(stream); 2142 object()->PrintNameTo(stream);
2133 stream->Add("["); 2143 stream->Add("[");
2134 key()->PrintNameTo(stream); 2144 key()->PrintNameTo(stream);
2135 stream->Add("] = "); 2145 stream->Add("] = ");
2136 value()->PrintNameTo(stream); 2146 value()->PrintNameTo(stream);
(...skipping 618 matching lines...) Expand 10 before | Expand all | Expand 10 after
2755 2765
2756 2766
2757 void HCheckFunction::Verify() { 2767 void HCheckFunction::Verify() {
2758 HInstruction::Verify(); 2768 HInstruction::Verify();
2759 ASSERT(HasNoUses()); 2769 ASSERT(HasNoUses());
2760 } 2770 }
2761 2771
2762 #endif 2772 #endif
2763 2773
2764 } } // namespace v8::internal 2774 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698