Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: media/audio/audio_io.h

Issue 11348166: Always wait for DataReady() on Windows WaveOut. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo! Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/media/audio_sync_reader.cc ('k') | media/audio/audio_output_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_io.h
diff --git a/media/audio/audio_io.h b/media/audio/audio_io.h
index cfc71bdb4681dedecad48f483c83a52973d892b6..e7b9a36011ef73332ae0607952ab4278759db92b 100644
--- a/media/audio/audio_io.h
+++ b/media/audio/audio_io.h
@@ -74,14 +74,10 @@ class MEDIA_EXPORT AudioOutputStream {
// specific.
virtual void OnError(AudioOutputStream* stream, int code) = 0;
- // Waits till data becomes available. Used when buffering data starting
- // new audio stream.
- // Polling is not the best approach, but incorporating messaging loop
- // with delayed tasks into guts of complex code is even worse, as it is
- // very error-prone. We cannot easily add synchronization, interface is
- // already cut in stone because of need of backward compatibility with
- // plugins. In any case, data is usually immediately available,
- // so there would be no delay.
+ // Deprecated. DO NOT USE. Waits until data becomes available. Used only
+ // by Windows' WaveOut clients which may be extremely laggy. Will yield the
+ // current thread until the renderer client has written its audio data or
+ // 1.5 seconds have elapsed.
virtual void WaitTillDataReady() {}
protected:
« no previous file with comments | « content/browser/renderer_host/media/audio_sync_reader.cc ('k') | media/audio/audio_output_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698