Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: media/audio/audio_io.h

Issue 11348166: Always wait for DataReady() on Windows WaveOut. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only wait on WaveOut. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_io.h
diff --git a/media/audio/audio_io.h b/media/audio/audio_io.h
index cfc71bdb4681dedecad48f483c83a52973d892b6..52e4f1ea92ab56e27a7552b51f67d4ab0e908455 100644
--- a/media/audio/audio_io.h
+++ b/media/audio/audio_io.h
@@ -74,14 +74,9 @@ class MEDIA_EXPORT AudioOutputStream {
// specific.
virtual void OnError(AudioOutputStream* stream, int code) = 0;
- // Waits till data becomes available. Used when buffering data starting
- // new audio stream.
- // Polling is not the best approach, but incorporating messaging loop
- // with delayed tasks into guts of complex code is even worse, as it is
- // very error-prone. We cannot easily add synchronization, interface is
- // already cut in stone because of need of backward compatibility with
- // plugins. In any case, data is usually immediately available,
- // so there would be no delay.
+ // Deprecated. DO NOT USE. Waits until data becomes available. Used only
+ // by Window's WaveOut clients which may be extremely laggy. Will yield the
scherkus (not reviewing) 2012/11/21 21:37:57 nit: Windows'
DaleCurtis 2012/11/21 22:42:10 Done.
+ // current thread until the renderer client has written its audio data.
virtual void WaitTillDataReady() {}
protected:

Powered by Google App Engine
This is Rietveld 408576698