Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 11348165: Remove PrefObserver usages, batch 10. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 6a7c445fbd20568153b20bc16a8164e751b6a83d..ef4056f58debde6c202b0bca18565fd47de272cd 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -448,12 +448,6 @@ void ExtensionSettingsHandler::Observe(
}
}
-void ExtensionSettingsHandler::OnPreferenceChanged(
- PrefServiceBase* service,
- const std::string& pref_name) {
- MaybeUpdateAfterNotification();
-}
-
void ExtensionSettingsHandler::ExtensionUninstallAccepted() {
DCHECK(!extension_id_prompting_.empty());
@@ -853,10 +847,14 @@ void ExtensionSettingsHandler::MaybeRegisterForNotifications() {
warning_service_observer_.Add(
extensions::ExtensionSystem::Get(profile)->warning_service());
+ base::Closure callback = base::Bind(
+ &ExtensionSettingsHandler::MaybeUpdateAfterNotification,
+ base::Unretained(this));
+
pref_registrar_.Init(profile->GetPrefs());
- pref_registrar_.Add(prefs::kExtensionInstallDenyList, this);
+ pref_registrar_.Add(prefs::kExtensionInstallDenyList, callback);
local_state_pref_registrar_.Init(g_browser_process->local_state());
- local_state_pref_registrar_.Add(prefs::kInManagedMode, this);
+ local_state_pref_registrar_.Add(prefs::kInManagedMode, callback);
}
std::vector<ExtensionPage>

Powered by Google App Engine
This is Rietveld 408576698