sdk/lib/_internal/compiler/implementation/lib/js_helper.dart - Issue 11348133: Add JSNull, JSBool and JSFunction, and move toString into the new interceptor scheme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 11348133: Add JSNull, JSBool and JSFunction, and move toString into the new interceptor scheme. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/js_number.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (revision 15139)

+++ sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (working copy)

@@ -944,7 +944,8 @@

// exception occurred.

var type = JS('var', r'#.type', ex);

var name = JS('var', r'#.arguments ? #.arguments[0] : ""', ex, ex);

- if (type == 'property_not_function' ||

+ if (message.contains('JSNull') ||

karlklose 2012/11/20 14:09:12 Where does this come from?

ngeoffray 2012/11/20 14:15:17 Take the call foo.forEach(...). Since forEach is i

+ type == 'property_not_function' ||

type == 'called_non_callable' ||

type == 'non_object_property_call' ||

type == 'non_object_property_load') {