Remove overhead of socket testing flags by storing the value in a static.

runtime/bin/socket.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/io_buffer.h"
 #include "bin/socket.h"
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
@@ skipping 89 matching lines @@
   } else {
     Dart_SetReturnValue(args, DartUtils::NewDartOSError());
   }
 
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Socket_ReadList)(Dart_NativeArguments args) {
   Dart_EnterScope();
+  static bool short_socket_reads = Dart_IsVMFlagSet("short_socket_read");
   Dart_Handle socket_obj = Dart_GetNativeArgument(args, 0);
   intptr_t socket = 0;
   Socket::GetSocketIdNativeField(socket_obj, &socket);
   Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
   int64_t offset = 0;
   int64_t length = 0;
   Dart_Handle offset_obj = Dart_GetNativeArgument(args, 2);
   Dart_Handle length_obj = Dart_GetNativeArgument(args, 3);
   if (Dart_IsList(buffer_obj) &&
       DartUtils::GetInt64Value(offset_obj, &offset) &&
       DartUtils::GetInt64Value(length_obj, &length)) {
     intptr_t buffer_len = 0;
     Dart_Handle result = Dart_ListLength(buffer_obj, &buffer_len);
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
     ASSERT((offset + length) <= buffer_len);
-    if (Dart_IsVMFlagSet("short_socket_read")) {
+    if (short_socket_reads) {
       length = (length + 1) / 2;
     }
     uint8_t* buffer = new uint8_t[length];
     intptr_t bytes_read = Socket::Read(socket, buffer, length);
     if (bytes_read > 0) {
       Dart_Handle result =
           Dart_ListSetAsBytes(buffer_obj, offset, buffer, bytes_read);
       if (Dart_IsError(result)) {
         delete[] buffer;
         Dart_PropagateError(result);
@@ skipping 11 matching lines @@
     if (Dart_IsError(err)) Dart_PropagateError(err);
     Dart_SetReturnValue(args, err);
   }
 
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Socket_WriteList)(Dart_NativeArguments args) {
   Dart_EnterScope();
+  static bool short_socket_writes = Dart_IsVMFlagSet("short_socket_write");
   Dart_Handle socket_obj = Dart_GetNativeArgument(args, 0);
   intptr_t socket = 0;
   Socket::GetSocketIdNativeField(socket_obj, &socket);
   Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
   ASSERT(Dart_IsList(buffer_obj));
   intptr_t offset =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 2));
   intptr_t length =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 3));
   intptr_t buffer_len = 0;
   Dart_Handle result = Dart_ListLength(buffer_obj, &buffer_len);
   if (Dart_IsError(result)) {
     Dart_PropagateError(result);
   }
   ASSERT((offset + length) <= buffer_len);
 
-  if (Dart_IsVMFlagSet("short_socket_write")) {
+  if (short_socket_writes) {
     length = (length + 1) / 2;
   }
 
   intptr_t total_bytes_written = 0;
   intptr_t bytes_written = 0;
   if (Dart_IsByteArrayExternal(buffer_obj)) {
     void* buffer = NULL;
     result = Dart_ExternalByteArrayGetData(buffer_obj, &buffer);
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
@@ skipping 227 matching lines @@
 
 
 Dart_Handle Socket::SetSocketIdNativeField(Dart_Handle socket, intptr_t id) {
   return Dart_SetNativeInstanceField(socket, kSocketIdNativeField, id);
 }
 
 
 Dart_Handle Socket::GetSocketIdNativeField(Dart_Handle socket, intptr_t* id) {
   return Dart_GetNativeInstanceField(socket, kSocketIdNativeField, id);
 }