Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 11348050: [VS Addin] Add automatic nmf creation (Closed)

Created:
8 years, 4 months ago by Sam Clegg
Modified:
8 years, 4 months ago
Reviewers:
binji, Noel Gordon
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VS Addin] Add automatic nmf creation BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1462

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -86 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Toolset.default.props View 1 chunk +1 line, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Props/nacl_link.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/Microsoft.Cpp.NaCl64.targets View 1 chunk +6 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/PNaCl/Microsoft.Cpp.PNaCl.targets View 1 1 chunk +1 line, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.vcxproj View 1 chunk +0 lines, -24 lines 0 comments Download
D visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/PNaCl/hello_world_gles.nmf View 1 chunk +0 lines, -8 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj View 1 chunk +0 lines, -12 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs View 1 4 chunks +116 lines, -29 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs View 2 chunks +9 lines, -1 line 0 comments Download
D visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution/NaClProject/nacl_project.nmf View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Clegg
This change is pipeline'd on top of the PNaCl VS integration.
8 years, 4 months ago (2012-10-30 22:58:02 UTC) #1
binji
8 years, 4 months ago (2012-10-30 23:38:39 UTC) #2
lgtm, but make sure this compiles!

http://codereview.chromium.org/11348050/diff/4001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs (right):

http://codereview.chromium.org/11348050/diff/4001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs:175: string
dirname = Path.GetDirectoryName(GenerateFullPathToTool();
doesn't look like this will compile -- missing close paren

http://codereview.chromium.org/11348050/diff/4001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs:249: string
nmfPath = Path.Combine(outputRoot, Path.ChangeExtension(ProjectName, ".nmf"));
just over 100 chars... :-/

http://codereview.chromium.org/11348050/diff/4001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs:292: protected
override int ExecuteTool(string pathToTool, string responseFileCommands, string
commandLineCommands)
nit: wrap at 100

http://codereview.chromium.org/11348050/diff/4001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs:296:
Log.LogMessage(MessageImportance.High, pathToTool + "  " + responseFileCommands
+ " " + commandLineCommands);
nit: wrap at 100

Powered by Google App Engine
This is Rietveld 408576698