dart/lib/compiler/implementation/js_backend/emitter.dart - Issue 11348037: A method or accessor with empty body is implicitly abstract.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/lib/compiler/implementation/js_backend/emitter.dart

Issue 11348037: A method or accessor with empty body is implicitly abstract. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Changes to make unit tests pass Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/lib/compiler/implementation/elements/elements.dart ('k') | dart/lib/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/lib/compiler/implementation/js_backend/emitter.dart

diff --git a/dart/lib/compiler/implementation/js_backend/emitter.dart b/dart/lib/compiler/implementation/js_backend/emitter.dart

index b9d30a3fa4b426e1d5f166bf42e43bd1bf763679..85ac2fe4f0da98878d1fdfebe11e26612d27408f 100644

--- a/dart/lib/compiler/implementation/js_backend/emitter.dart

+++ b/dart/lib/compiler/implementation/js_backend/emitter.dart

@@ -586,9 +586,8 @@ function(prototype, staticName, fieldName, getterName, lazyValue) {

if (member.isFunction()

|| member.isGenerativeConstructorBody()

- || member.isGetter()

- || member.isSetter()) {

- if (member.modifiers.isAbstract()) return;

+ || member.isAccessor()) {

+ if (member.isAbstract(compiler)) return;

CodeBuffer codeBuffer = compiler.codegenWorld.generatedCode[member];

if (codeBuffer == null) return;

defineInstanceMember(namer.getName(member), codeBuffer);

« no previous file with comments | « dart/lib/compiler/implementation/elements/elements.dart ('k') | dart/lib/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »