Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: pkg/dartdoc/lib/mirrors.dart

Issue 11348036: Alignments for the ClassMirror interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dartdoc/lib/mirrors.dart
diff --git a/pkg/dartdoc/lib/mirrors.dart b/pkg/dartdoc/lib/mirrors.dart
index 6025c10a8e597f081d284c4bc906baae588f7359..dbf6e1eeeb752362902822702a0b1b13ea408ce3 100644
--- a/pkg/dartdoc/lib/mirrors.dart
+++ b/pkg/dartdoc/lib/mirrors.dart
@@ -232,9 +232,15 @@ abstract class TypeMirror implements DeclarationMirror {
*/
abstract class ClassMirror implements TypeMirror, ObjectMirror {
/**
- * Returns the defining type, i.e. declaration of a type.
+ * A mirror on the original declaration of this type.
+ *
+ * For most classes, they are their own original declaration. For
+ * generic classes, however, there is a distinction between the
+ * original class declaration, which has unbound type variables, and
+ * the instantiations of generic classes, which have bound type
+ * variables.
*/
- ClassMirror get declaration;
+ ClassMirror get originalDeclaration;
/**
* Returns the super class of this type, or null if this type is [Object] or a
@@ -245,7 +251,7 @@ abstract class ClassMirror implements TypeMirror, ObjectMirror {
/**
* Returns a list of the interfaces directly implemented by this type.
*/
- List<ClassMirror> get interfaces;
+ List<ClassMirror> get superinterfaces;
/**
* Is [:true:] iff this type is a class.
@@ -258,9 +264,15 @@ abstract class ClassMirror implements TypeMirror, ObjectMirror {
bool get isInterface;
/**
- * Is [:true:] if this type is the declaration of a type.
+ * Is this the original declaration of this type?
+ *
+ * For most classes, they are their own original declaration. For
+ * generic classes, however, there is a distinction between the
+ * original class declaration, which has unbound type variables, and
+ * the instantiations of generic classes, which have bound type
+ * variables.
*/
- bool get isDeclaration;
+ bool get isOriginalDeclaration;
/**
* Is [:true:] if this class is declared abstract.
@@ -285,7 +297,7 @@ abstract class ClassMirror implements TypeMirror, ObjectMirror {
/**
* Returns the default type for this interface.
*/
- ClassMirror get defaultType;
+ ClassMirror get defaultFactory;
}
/**

Powered by Google App Engine
This is Rietveld 408576698