content/renderer/render_widget.cc - Issue 11348033: Initialize device scale factor correctly on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget.cc

Issue 11348033: Initialize device scale factor correctly on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Simpler fix and better test Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_widget.cc

diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc

index cb8b30d22e3440891f9686ed2b622d5380feda98..0cd9cf401bb8fefd75d691eb44f3333a375cb382 100644

--- a/content/renderer/render_widget.cc

+++ b/content/renderer/render_widget.cc

@@ -117,7 +117,8 @@ RenderWidget::RenderWidget(WebKit::WebPopupType popup_type,

DCHECK(RenderThread::Get());

has_disable_gpu_vsync_switch_ = CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisableGpuVsync);

-#if defined(OS_CHROMEOS) || defined(OS_MACOSX)

+ // TODO(skyostil): Move device scale factor initialization to gfx::Display.

+#if defined(OS_CHROMEOS) || defined(OS_MACOSX) || defined(OS_ANDROID)

johnme 2012/10/31 11:48:37 Woah, this code path includes a static_cast<int>;

Sami 2012/10/31 11:51:40 Ack, serves me right for not re-testing on all dev

device_scale_factor_ = screen_info.verticalDPI / kStandardDPI;

// Unless an explicit scale factor was provided for testing, ensure the scale

// is integral.

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | no next file » | no next file with comments »