vm/parser.cc - Issue 11348026: - GrowableArray::RemoveLast returns the value being removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/parser.cc

Issue 11348026: - GrowableArray::RemoveLast returns the value being removed (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/parser.cc

===================================================================

--- vm/parser.cc (revision 14219)

+++ vm/parser.cc (working copy)

@@ -976,16 +976,13 @@

token_stack.Add(token);

break;

case Token::kRBRACE:

- is_match = token_stack.Last() == Token::kLBRACE;

- token_stack.RemoveLast();

+ is_match = token_stack.RemoveLast() == Token::kLBRACE;

break;

case Token::kRPAREN:

- is_match = token_stack.Last() == Token::kLPAREN;

- token_stack.RemoveLast();

+ is_match = token_stack.RemoveLast() == Token::kLPAREN;

break;

case Token::kRBRACK:

- is_match = token_stack.Last() == Token::kLBRACK;

- token_stack.RemoveLast();

+ is_match = token_stack.RemoveLast() == Token::kLBRACK;

break;

case Token::kEOS:

unexpected_token_found = true;

« no previous file with comments | « vm/growable_array.h ('k') | vm/scavenger.cc » ('j') | no next file with comments »