Fix GenerateIndex for gsutil directories by stripping colon off directory names.

gsd_generate_index.py

 #!/usr/bin/python
 # Copyright (c) 2008-2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generate index.html files for a Google Storage for Developers directory.
 
 Google Storage for Developers provides only a raw set of objects.
 For some buckets we would like to be able to support browsing of the directory
 tree. This utility will generate the needed index and upload/update it.
@@ skipping 152 matching lines @@
 
 def GenerateIndexes(path, options):
   """Generate all relevant indexes for a given gsd path."""
   # Get a list of objects under this prefix.
   cmd = [options.gsutil, 'ls', posixpath.join(path, '*')]
   p = subprocess.Popen(cmd, stdout=subprocess.PIPE)
   p_stdout, _ = p.communicate()
   assert p.returncode == 0
   objects = str(p_stdout).splitlines()
   objects = [o for o in objects if posixpath.basename(o) != GENERATED_INDEX]
+  def strip_colon(dir_str): return dir_str.rstrip(':')
+  objects = map(strip_colon, objects)

[Isaac (away), 2012/10/29 23:49:24]

use lambda fun or else list comprehension:

objects = [path.rstrip(':') for path in objects]

   # Find common prefixes.
   directories = set()
   for o in objects:
     part = posixpath.dirname(o)
     while part.startswith(path):
       directories.add(part)
       part = posixpath.dirname(part)
   objects += list(directories)
   # Generate index for each directory.
   index_list = [i for i in directories
@@ skipping 27 matching lines @@
                     dest='gsutil', help='path to gsutil')
   options, args = parser.parse_args(argv)
   if len(args) != 2 or not args[1].startswith('gs://'):
     parser.print_help()
     return 1
   return GenerateIndexes(args[1], options)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))