Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/CompilationUnitDocumentProvider.java

Issue 11348017: Making save a little faster: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/CompilationUnitDocumentProvider.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/CompilationUnitDocumentProvider.java (revision 14360)
+++ editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/CompilationUnitDocumentProvider.java (working copy)
@@ -67,7 +67,6 @@
import org.eclipse.core.runtime.ListenerList;
import org.eclipse.core.runtime.MultiStatus;
import org.eclipse.core.runtime.NullProgressMonitor;
-import org.eclipse.core.runtime.OperationCanceledException;
import org.eclipse.core.runtime.SafeRunner;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.SubProgressMonitor;
@@ -1065,39 +1064,9 @@
monitor = new NullProgressMonitor();
}
- monitor.beginTask("", 120); //$NON-NLS-1$
+ monitor.beginTask("", 70); //$NON-NLS-1$
try {
- final IProgressMonitor subMonitor1 = getSubProgressMonitor(monitor, 50);
-
- try {
- SafeRunner.run(new ISafeRunnable() {
- @Override
- public void handleException(Throwable ex) {
- IStatus status = new Status(
- IStatus.ERROR,
- DartUI.ID_PLUGIN,
- IStatus.OK,
- "Error in Dart Core during reconcile while saving", ex); //$NON-NLS-1$
- DartToolsPlugin.getDefault().getLog().log(status);
- }
-
- @Override
- public void run() {
- try {
- DartX.todo();
- ((CompilationUnitImpl) info.fCopy).reconcile(false, subMonitor1);
- } catch (DartModelException ex) {
- handleException(ex);
- } catch (OperationCanceledException ex) {
- // do not log this
- }
- }
- });
- } finally {
- subMonitor1.done();
- }
-
IDocument document = info.fTextFileBuffer.getDocument();
DartX.todo();
boolean isSynchronized = true;

Powered by Google App Engine
This is Rietveld 408576698