compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java - Issue 11348017: Making save a little faster:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

Issue 11348017: Making save a little faster: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

===================================================================

--- compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (revision 14360)

+++ compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (working copy)

@@ -557,9 +557,9 @@

* Checks that top-level "main()" has no parameters.

private void checkTopLevelMainFunction(DartMethodDefinition method) {

- if (Objects.equal(method.getName().toSource(), "main")

+ if (!method.getFunction().getParameters().isEmpty()

&& currentHolder instanceof LibraryElement

- && !method.getFunction().getParameters().isEmpty()) {

+ && Objects.equal(method.getName().toString(), "main")) {

resolutionError(method.getName(), ResolverErrorCode.MAIN_FUNCTION_PARAMETERS);

}