Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 11348011: Revert 128789 - IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor (Closed)

Created:
8 years, 1 month ago by alecflett
Modified:
8 years, 1 month ago
Reviewers:
alecflett
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Revert 128789 - IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor https://bugs.webkit.org/show_bug.cgi?id=95409 Patch by Alec Flett <alecflett@chromium.org>; on 2012-09-17 Reviewed by Kentaro Hara. Source/WebCore: This reduces a bunch of serialization/deserialization when writing to objectstores with indexes. No new tests, as this covers core functionality of IndexedDB, and almost every test would fail. Some likely tests that would fail fundamentally include: storage/indexeddb/objectstore-basics.html storage/indexeddb/cursor-basics.html storage/indexeddb/index-basics.html * Modules/indexeddb/IDBAny.cpp: (WebCore::IDBAny::scriptValue): (WebCore::IDBAny::integer): (WebCore): (WebCore::IDBAny::set): * Modules/indexeddb/IDBAny.h: (WebCore): (IDBAny): (WebCore::IDBAny::create): * Modules/indexeddb/IDBCursor.cpp: (WebCore::IDBCursor::setValueReady): * Modules/indexeddb/IDBCursor.h: (WebCore): (IDBCursor): * Modules/indexeddb/IDBDatabase.cpp: (WebCore::IDBDatabase::version): * Modules/indexeddb/IDBObjectStore.cpp: (WebCore): * Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::setResultCursor): (WebCore::IDBRequest::onSuccess): (WebCore): (WebCore::IDBRequest::onSuccessInternal): (WebCore::IDBRequest::dispatchEvent): * Modules/indexeddb/IDBRequest.h: (IDBRequest): * Modules/indexeddb/IDBTransactionCallbacks.h: * bindings/v8/IDBBindingUtilities.cpp: (WebCore::deserializeIDBValue): (WebCore::injectIDBKeyIntoScriptValue): * bindings/v8/IDBBindingUtilities.h: (WebCore): * bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8): Source/WebKit/chromium: This removes a bunch of tests that have been migrated to LayoutTests, in https://bugs.webkit.org/show_bug.cgi?id=96818. * tests/IDBBindingUtilitiesTest.cpp: (WebCore::checkKeyFromValueAndKeyPathInternal): (WebCore::checkKeyPathNullValue): (WebCore::injectKey): (WebCore::checkInjection): (WebCore::checkInjectionFails): (WebCore::checkKeyPathStringValue): (WebCore::checkKeyPathNumberValue): (WebCore::TEST): * tests/IDBKeyPathTest.cpp: TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -117 lines) Patch
M Source/WebCore/Modules/indexeddb/IDBAny.h View 8 chunks +7 lines, -18 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBAny.cpp View 5 chunks +7 lines, -19 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBCursor.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBCursor.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBRequest.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBRequest.cpp View 6 chunks +19 lines, -21 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBTransactionCallbacks.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/bindings/v8/IDBBindingUtilities.h View 1 chunk +4 lines, -1 line 0 comments Download
M Source/WebCore/bindings/v8/IDBBindingUtilities.cpp View 3 chunks +48 lines, -6 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/WebKit/chromium/tests/IDBBindingUtilitiesTest.cpp View 8 chunks +33 lines, -35 lines 0 comments Download
M Source/WebKit/chromium/tests/IDBKeyPathTest.cpp View 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
alecflett
8 years, 1 month ago (2012-10-29 17:44:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698