[Sync] WriteNode::SetTitle doesn't update bookmark title when it is empty string.

[Sync] WriteNode::SetTitle doesn't update bookmark title when it is empty string.

WriteNode::SetTitle copies title into bookmark specifics title for
bookmark entries. When title for newly created bookmark is empty
WriteNode::SetTitle exits early and doesn't update
BookmarkSpecifics.title.

This change ensures that title is updated.

BUG=486407
R=zea@chromium.org
TEST=
- Import bookmarks file attached in the bug. There should be 2 bookmarks with empty titles.
- Create new client for the same account and make sure that both bookmarks get synced.

Committed: https://crrev.com/b74e4a779fbcac72d7fd0654f1e7218642cdef29
Cr-Commit-Position: refs/heads/master@{#330420}

[Nicolas Zea, 2015-05-15 20:15:18]

https://codereview.chromium.org/1134793006/diff/20001/sync/internal_api/write...
File sync/internal_api/write_node.cc (right):

https://codereview.chromium.org/1134793006/diff/20001/sync/internal_api/write...
sync/internal_api/write_node.cc:80: bool bookmark_title_updated = false;
Does it make sense to, instead of having this new boolean, to just update
title_matches above to be false if specifics.bookmark().title() !=
new_legal_title?

[pavely, 2015-05-15 21:45:29]

https://codereview.chromium.org/1134793006/diff/20001/sync/internal_api/write...
File sync/internal_api/write_node.cc (right):

https://codereview.chromium.org/1134793006/diff/20001/sync/internal_api/write...
sync/internal_api/write_node.cc:80: bool bookmark_title_updated = false;
On 2015/05/15 20:15:17, Nicolas Zea wrote:
> Does it make sense to, instead of having this new boolean, to just update
> title_matches above to be false if specifics.bookmark().title() !=
> new_legal_title?

I used title_matches first, but decided to use separate variable because
title_matches reflects comparison of NonUniqueName(), not bookmark's title. I
think updating title_matches is fine. I'll change code.

[Nicolas Zea, 2015-05-15 22:10:15]

lgtm

[pavely, 2015-05-15 22:14:39]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2015-05-15 22:15:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134793006/40001

[commit-bot: I haz the power, 2015-05-16 03:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-16 03:45:46]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[pavely, 2015-05-18 18:43:46]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2015-05-18 18:45:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134793006/40001

[commit-bot: I haz the power, 2015-05-18 21:01:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-18 22:43:25]

Patchset 3 (id:??) landed as
https://crrev.com/b74e4a779fbcac72d7fd0654f1e7218642cdef29
Cr-Commit-Position: refs/heads/master@{#330420}