Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 1134793005: [Android] Add a regression test for the JB RemoveHolderAndAdvanceLocked issue (Closed)

Created:
5 years, 7 months ago by mnaganov (inactive)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add a regression test for the JB RemoveHolderAndAdvanceLocked issue This is a re-land of https://codereview.chromium.org/1134543002/ with a workaround for http://crbug.com/486262, which was causing the initial test instability. The test reproduces the condition which was triggering an infinite loop inside GinJavaBridgeDispatcherHost::RenderFrameDeleted. Verified that the test indeed hangs up and timeouts if the fix is removed. BUG=484927, 486262 TBR=sgurun@chromium.org,tedchoc@chromium.org Committed: https://crrev.com/c4e3f83f536d12fce6e01343af548fa50a4b7c25 Cr-Commit-Position: refs/heads/master@{#330135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 2 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mnaganov (inactive)
TBRing you guys, as the meat of the test didn't change, it's just a minor ...
5 years, 7 months ago (2015-05-15 17:34:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134793005/1
5 years, 7 months ago (2015-05-15 17:36:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 18:14:41 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 18:16:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4e3f83f536d12fce6e01343af548fa50a4b7c25
Cr-Commit-Position: refs/heads/master@{#330135}

Powered by Google App Engine
This is Rietveld 408576698