Place SessionRestore/MemoryPressure interactions behind a field trial on Mac/Win platforms.

Place SessionRestore/MemoryPressure interactions behind a field trial on Mac/Win platforms.

BUG=472772
Committed: https://crrev.com/20a481c1b17530f67a9ae18488582fb8b8bcf475
Cr-Commit-Position: refs/heads/master@{#329183}

[chrisha, 2015-05-08 16:43:46]

chrisha@chromium.org changed reviewers:
+ sky@chromium.org

[chrisha, 2015-05-08 16:43:47]

PTAL?

[sky, 2015-05-08 17:37:25]

https://codereview.chromium.org/1134783002/diff/1/chrome/browser/sessions/tab...
File chrome/browser/sessions/tab_loader.cc (right):

https://codereview.chromium.org/1134783002/diff/1/chrome/browser/sessions/tab...
chrome/browser/sessions/tab_loader.cc:188: #if defined(OS_WIN) ||
(defined(OS_MACOSX) && !defined(OS_IOS))
The problem with memory pressure or network disconnects is it means all the time
related histograms are completely wrong. By that I mean if we get memory
pressure during session restore we stop loading subsequent tabs. That
effectively means the histograms are not correct. That needs to be fixed before
we turn this on.

[chrisha, 2015-05-08 19:26:06]

Ah, okay. I hadn't understood your original objection.

Probably best to let this CL land then as is, because it actually *disables* the
memory pressure connection, which is enabled by default right now (and has been
for quite some time on ChromeOS).

I can take care of cleaning up the stats in the metrics CL.

Sound reasonable?

[sky, 2015-05-08 21:10:06]

Perfect.

On Fri, May 8, 2015 at 12:26 PM,  <chrisha@chromium.org> wrote:
> Ah, okay. I hadn't understood your original objection.
>
> Probably best to let this CL land then as is, because it actually *disables*
> the
> memory pressure connection, which is enabled by default right now (and has
> been
> for quite some time on ChromeOS).
>
> I can take care of cleaning up the stats in the metrics CL.
>
> Sound reasonable?
>
> https://codereview.chromium.org/1134783002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chrisha, 2015-05-08 21:11:28]

Perfect, land this CL, or perfect not land this CL?

On Fri, May 8, 2015, 17:10 Scott Violet <sky@chromium.org> wrote:

> Perfect.
>
> On Fri, May 8, 2015 at 12:26 PM,  <chrisha@chromium.org> wrote:
> > Ah, okay. I hadn't understood your original objection.
> >
> > Probably best to let this CL land then as is, because it actually
> *disables*
> > the
> > memory pressure connection, which is enabled by default right now (and
> has
> > been
> > for quite some time on ChromeOS).
> >
> > I can take care of cleaning up the stats in the metrics CL.
> >
> > Sound reasonable?
> >
> > https://codereview.chromium.org/1134783002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2015-05-09 15:07:02]

Yes, sorry, LGTM

[chrisha, 2015-05-11 16:42:26]

The CQ bit was checked by chrisha@chromium.org

[chrisha, 2015-05-11 16:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1134783002/#ps20001
(title: "Fix wrong include.")

[commit-bot: I haz the power, 2015-05-11 16:43:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134783002/20001

[commit-bot: I haz the power, 2015-05-11 18:03:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-11 18:04:59]

Patchset 2 (id:??) landed as
https://crrev.com/20a481c1b17530f67a9ae18488582fb8b8bcf475
Cr-Commit-Position: refs/heads/master@{#329183}