Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: runtime/vm/raw_object.h

Issue 1134773003: Small cid (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index ceed53dab8ae8868116dc7baac8208f89fb8f317..22c7677c16c5bbc250b7cbfcf01ceb1cdd71f7b9 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -237,7 +237,7 @@ class RawObject {
kCanonicalBit = 2,
kFromSnapshotBit = 3,
kRememberedBit = 4,
- kReservedTagPos = 5, // kReservedBit{10K,100K,1M,10M}
+ kReservedTagPos = 5, // kReservedBit{100K,1M,10M}
kReservedTagSize = 3,
kSizeTagPos = kReservedTagPos + kReservedTagSize, // = 8
kSizeTagSize = 8,
@@ -609,11 +609,11 @@ class RawClass : public RawObject {
}
cpp_vtable handle_vtable_;
- int32_t id_; // Class Id, also index in the class table.
int32_t token_pos_;
int32_t instance_size_in_words_; // Size if fixed len or 0 if variable len.
int32_t type_arguments_field_offset_in_words_; // Offset of type args fld.
int32_t next_field_offset_in_words_; // Offset of the next instance field.
+ cid_t id_; // Class Id, also index in the class table.
int16_t num_type_arguments_; // Number of type arguments in flatten vector.
int16_t num_own_type_arguments_; // Number of non-overlapping type arguments.
uint16_t num_native_fields_; // Number of native fields in class.
@@ -752,7 +752,7 @@ class RawFunction : public RawObject {
int16_t num_fixed_parameters_;
int16_t num_optional_parameters_; // > 0: positional; < 0: named.
int16_t deoptimization_counter_;
- int16_t regexp_cid_;
+ cid_t regexp_cid_;
uint32_t kind_tag_; // See Function::KindTagBits.
uint16_t optimized_instruction_count_;
uint16_t optimized_call_site_count_;
@@ -810,6 +810,7 @@ class RawField : public RawObject {
}
int32_t token_pos_;
+ // TODO(rmacnak): Make these cid_t.
int32_t guarded_cid_;
int32_t is_nullable_; // kNullCid if field can contain null value and
// any other value otherwise.
@@ -911,15 +912,15 @@ class RawLibrary : public RawObject {
return reinterpret_cast<RawObject**>(&ptr()->load_error_);
}
- int32_t index_; // Library id number.
- int32_t num_imports_; // Number of entries in imports_.
- int32_t num_anonymous_; // Number of entries in anonymous_classes_.
Dart_NativeEntryResolver native_entry_resolver_; // Resolves natives.
Dart_NativeEntrySymbol native_entry_symbol_resolver_;
+ cid_t index_; // Library id number.
+ cid_t num_imports_; // Number of entries in imports_.
+ cid_t num_anonymous_; // Number of entries in anonymous_classes_.
+ int8_t load_state_; // Of type LibraryState.
bool corelib_imported_;
bool is_dart_scheme_;
- bool debuggable_; // True if debugger can stop in library.
- int8_t load_state_; // Of type LibraryState.
+ bool debuggable_; // True if debugger can stop in library.
friend class Isolate;
};
@@ -1421,7 +1422,7 @@ class RawLibraryPrefix : public RawInstance {
RawObject** to() {
return reinterpret_cast<RawObject**>(&ptr()->dependent_code_);
}
- int32_t num_imports_; // Number of library entries in libraries_.
+ cid_t num_imports_; // Number of library entries in libraries_.
bool is_deferred_load_;
bool is_loaded_;
};
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698