chrome/browser/BUILD.gn - Issue 1134753011: Fix missing GN dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 1134753011: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index a24f6f327ff65ef5374371399e8676a3fa8dd76a..e6140535026cc5b5f29139acdd9e778f9321a846 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -852,6 +852,10 @@ grit("resources") {

deps = [

":about_credits",

":chrome_internal_resources_gen",

+ # Depend only on the generated mojo bindings since we read the .mojom.js

+ # file, rather than the whole mojo target which will link the C++ bindings.

+ "//chrome/browser/ui/webui/omnibox:mojo_bindings__generator",

]

inputs = [

omnibox_mojom_file,

« no previous file with comments | « chrome/app/BUILD.gn ('k') | chrome/browser/ui/libgtk2ui/BUILD.gn » ('j') | no next file with comments »