Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1134753009: Remove enable_polymer_v08 flag from build (Closed)

Created:
5 years, 7 months ago by michaelpg
Modified:
5 years, 7 months ago
Reviewers:
Jeremy Klein, oshima
CC:
chromium-reviews, oshima+watch_chromium.org, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove enable_polymer_v08 flag from build Always build Polymer 0.8 and 0.5. Polymer 0.5 should be removed in M45. BUG=483080 R=jlklein@chromium.org TEST=manual Committed: https://crrev.com/41e9150f4aec3cd3ca2f9078252d24523993edc8 Cr-Commit-Position: refs/heads/master@{#330666}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -445 lines) Patch
M ui/resources/BUILD.gn View 3 chunks +0 lines, -11 lines 0 comments Download
M ui/resources/ui_resources.gyp View 2 chunks +0 lines, -9 lines 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 2 2 chunks +79 lines, -80 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 2 chunks +344 lines, -345 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
michaelpg
+oshima@ for ui/resources
5 years, 7 months ago (2015-05-19 23:11:44 UTC) #2
Jeremy Klein
lgtm Let's also add a TODO or NOTE in the grds that 0.5 stuff will ...
5 years, 7 months ago (2015-05-19 23:16:47 UTC) #3
michaelpg
On 2015/05/19 23:16:47, Jeremy Klein wrote: > lgtm > > Let's also add a TODO ...
5 years, 7 months ago (2015-05-19 23:27:13 UTC) #4
oshima
lgtm
5 years, 7 months ago (2015-05-19 23:33:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753009/40001
5 years, 7 months ago (2015-05-20 00:21:43 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 01:16:29 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 01:22:56 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/41e9150f4aec3cd3ca2f9078252d24523993edc8
Cr-Commit-Position: refs/heads/master@{#330666}

Powered by Google App Engine
This is Rietveld 408576698