|
|
DescriptionAdd ColorMatrix filter tests from Android CTS.
BUG=skia:3848
Committed: https://skia.googlesource.com/skia/+/b500ffa1a253dca35a7ff846ebece9fe570e3565
Patch Set 1 #
Total comments: 2
Patch Set 2 : windows fix #Patch Set 3 : #Messages
Total messages: 23 (11 generated)
djsollen@google.com changed reviewers: + reed@google.com
djsollen@google.com changed reviewers: + scroggo@google.com
lgtm https://codereview.chromium.org/1134753008/diff/1/tests/ColorMatrixTest.cpp File tests/ColorMatrixTest.cpp (right): https://codereview.chromium.org/1134753008/diff/1/tests/ColorMatrixTest.cpp#n... tests/ColorMatrixTest.cpp:28: static inline void test_colorMatrix(skiatest::Reporter* reporter) { Why is this its own function? Why not just use DEF_TEST here?
The CQ bit was checked by djsollen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753008/1
https://codereview.chromium.org/1134753008/diff/1/tests/ColorMatrixTest.cpp File tests/ColorMatrixTest.cpp (right): https://codereview.chromium.org/1134753008/diff/1/tests/ColorMatrixTest.cpp#n... tests/ColorMatrixTest.cpp:28: static inline void test_colorMatrix(skiatest::Reporter* reporter) { On 2015/05/19 20:10:44, scroggo wrote: > Why is this its own function? Why not just use DEF_TEST here? Personal preference. My intention was that this method would just replicate the CTS test and additional methods could be added for other colorMatrix tests. However, I should have named this test_colorMatrix_CTS or something like that.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by djsollen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com Link to the patchset: https://codereview.chromium.org/1134753008/#ps20001 (title: "windows fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753008/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by djsollen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com Link to the patchset: https://codereview.chromium.org/1134753008/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753008/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by djsollen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753008/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/b500ffa1a253dca35a7ff846ebece9fe570e3565 |