Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1134753008: Add ColorMatrix filter tests from Android CTS. (Closed)

Created:
5 years, 7 months ago by djsollen
Modified:
5 years, 6 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ColorMatrix filter tests from Android CTS. BUG=skia:3848 Committed: https://skia.googlesource.com/skia/+/b500ffa1a253dca35a7ff846ebece9fe570e3565

Patch Set 1 #

Total comments: 2

Patch Set 2 : windows fix #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
A tests/ColorMatrixTest.cpp View 1 2 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
djsollen
5 years, 7 months ago (2015-05-19 19:18:58 UTC) #2
djsollen
5 years, 7 months ago (2015-05-19 20:03:00 UTC) #4
scroggo
lgtm https://codereview.chromium.org/1134753008/diff/1/tests/ColorMatrixTest.cpp File tests/ColorMatrixTest.cpp (right): https://codereview.chromium.org/1134753008/diff/1/tests/ColorMatrixTest.cpp#newcode28 tests/ColorMatrixTest.cpp:28: static inline void test_colorMatrix(skiatest::Reporter* reporter) { Why is ...
5 years, 7 months ago (2015-05-19 20:10:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753008/1
5 years, 7 months ago (2015-05-19 20:23:13 UTC) #7
djsollen
https://codereview.chromium.org/1134753008/diff/1/tests/ColorMatrixTest.cpp File tests/ColorMatrixTest.cpp (right): https://codereview.chromium.org/1134753008/diff/1/tests/ColorMatrixTest.cpp#newcode28 tests/ColorMatrixTest.cpp:28: static inline void test_colorMatrix(skiatest::Reporter* reporter) { On 2015/05/19 20:10:44, ...
5 years, 7 months ago (2015-05-19 20:24:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/1178)
5 years, 7 months ago (2015-05-19 20:27:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753008/20001
5 years, 7 months ago (2015-05-19 20:42:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/1180)
5 years, 7 months ago (2015-05-19 20:46:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753008/40001
5 years, 6 months ago (2015-06-04 17:16:17 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_TIMED_OUT, no build URL)
5 years, 6 months ago (2015-06-04 19:16:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753008/40001
5 years, 6 months ago (2015-06-05 16:38:24 UTC) #22
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:41:24 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b500ffa1a253dca35a7ff846ebece9fe570e3565

Powered by Google App Engine
This is Rietveld 408576698