Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1134753004: Update Sudden Motion Sensor notes for early 2015 Apple notebook computers. (Closed)

Created:
5 years, 7 months ago by Avi (use Gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Sudden Motion Sensor notes for early 2015 Apple notebook computers. BUG=none TEST=none Committed: https://crrev.com/b31210c4f4ee8983783e8a3abe71665a43d9bb68 Cr-Commit-Position: refs/heads/master@{#330377}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc View 3 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
Avi (use Gerrit)
Robert: Mark is out, so you get the honor of approving the hard-won results of ...
5 years, 7 months ago (2015-05-17 23:16:56 UTC) #2
Robert Sesek
LGTM Seems like Apple are trending towards not including accelerometers? https://codereview.chromium.org/1134753004/diff/1/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc File third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc (right): https://codereview.chromium.org/1134753004/diff/1/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc#newcode139 ...
5 years, 7 months ago (2015-05-18 15:55:48 UTC) #3
Avi (use Gerrit)
Definitely a trend. The point of the SMS was to detect a fall to shut ...
5 years, 7 months ago (2015-05-18 16:01:16 UTC) #4
Avi (use Gerrit)
On 2015/05/18 16:01:16, Avi wrote: > Definitely a trend. The point of the SMS was ...
5 years, 7 months ago (2015-05-18 16:01:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753004/1
5 years, 7 months ago (2015-05-18 16:02:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 16:55:05 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:40:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b31210c4f4ee8983783e8a3abe71665a43d9bb68
Cr-Commit-Position: refs/heads/master@{#330377}

Powered by Google App Engine
This is Rietveld 408576698