Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: content/child/push_messaging/push_provider.h

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Review Comments 2 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/push_messaging/push_provider.h
diff --git a/content/child/push_messaging/push_provider.h b/content/child/push_messaging/push_provider.h
index 47442ae0230820edd0ba183b93ac7531a3347b8e..fe29c32a25eb7f40245b37179ca80e0db2764da9 100644
--- a/content/child/push_messaging/push_provider.h
+++ b/content/child/push_messaging/push_provider.h
@@ -63,14 +63,14 @@ class PushProvider : public blink::WebPushProvider,
PushDispatcher* push_dispatcher);
// IPC message handlers.
- void OnRegisterFromWorkerSuccess(int request_id,
- const GURL& endpoint,
- const std::string& registration_id);
- void OnRegisterFromWorkerError(int request_id, PushRegistrationStatus status);
- void OnUnregisterSuccess(int request_id, bool did_unregister);
- void OnUnregisterError(int request_id,
- blink::WebPushError::ErrorType error_type,
- const std::string& error_message);
+ void OnSubscribeFromWorkerSuccess(int request_id,
+ const GURL& endpoint,
+ const std::string& subscription_id);
+ void OnSubscribeFromWorkerError(int request_id, PushRegistrationStatus status);
davidben 2015/05/19 20:10:28 80 character column limit
Pranay 2015/05/20 03:51:57 Done.
+ void OnUnsubscribeSuccess(int request_id, bool did_unsubscribe);
+ void OnUnsubscribeError(int request_id,
+ blink::WebPushError::ErrorType error_type,
+ const std::string& error_message);
void OnGetRegistrationSuccess(int request_id,
const GURL& endpoint,
const std::string& registration_id);

Powered by Google App Engine
This is Rietveld 408576698