Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2576)

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.h

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set 2 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_push_messaging_service.h
diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.h b/content/shell/browser/layout_test/layout_test_push_messaging_service.h
index 2a472ec3280b32d4ed06093f36022e00cc4c53b1..b436d0aad92a16b33643659e82cd7371cc4eb1dd 100644
--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.h
+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.h
@@ -21,7 +21,7 @@ class LayoutTestPushMessagingService : public PushMessagingService {
// PushMessagingService implementation:
GURL GetPushEndpoint() override;
- void RegisterFromDocument(
+ void SubscribeFromDocument(
const GURL& requesting_origin,
int64 service_worker_registration_id,
const std::string& sender_id,
@@ -29,7 +29,7 @@ class LayoutTestPushMessagingService : public PushMessagingService {
int render_frame_id,
bool user_visible,
const PushMessagingService::RegisterCallback& callback) override;
- void RegisterFromWorker(
+ void SubscribeFromWorker(
const GURL& requesting_origin,
int64 service_worker_registration_id,
const std::string& sender_id,
@@ -40,7 +40,7 @@ class LayoutTestPushMessagingService : public PushMessagingService {
const GURL& embedding_origin,
bool user_visible) override;
bool SupportNonVisibleMessages() override;
- void Unregister(const GURL& requesting_origin,
+ void Unsubscribe(const GURL& requesting_origin,
int64 service_worker_registration_id,
Peter Beverloo 2015/05/18 12:44:37 nit: indentation +1
Pranay 2015/05/19 04:40:40 Done.
const std::string& sender_id,
const UnregisterCallback& callback) override;

Powered by Google App Engine
This is Rietveld 408576698