Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.cc

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set 2 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_push_messaging_service.cc
diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.cc b/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
index 3b71a2e5179bf7a7dd0406be07ddac6ba612501c..1adf96abfe55c8a26eee300c1b064c1513a6ed77 100644
--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
@@ -42,7 +42,7 @@ GURL LayoutTestPushMessagingService::GetPushEndpoint() {
return GURL("https://example.com/LayoutTestEndpoint");
}
-void LayoutTestPushMessagingService::RegisterFromDocument(
+void LayoutTestPushMessagingService::SubscribeFromDocument(
const GURL& requesting_origin,
int64 service_worker_registration_id,
const std::string& sender_id,
@@ -50,11 +50,11 @@ void LayoutTestPushMessagingService::RegisterFromDocument(
int render_frame_id,
bool user_visible,
const PushMessagingService::RegisterCallback& callback) {
- RegisterFromWorker(requesting_origin, service_worker_registration_id,
+ SubscribeFromWorker(requesting_origin, service_worker_registration_id,
sender_id, user_visible, callback);
Peter Beverloo 2015/05/18 12:44:37 nit: indentation +1
Pranay 2015/05/19 04:40:40 Done.
}
-void LayoutTestPushMessagingService::RegisterFromWorker(
+void LayoutTestPushMessagingService::SubscribeFromWorker(
const GURL& requesting_origin,
int64 service_worker_registration_id,
const std::string& sender_id,
@@ -86,7 +86,7 @@ bool LayoutTestPushMessagingService::SupportNonVisibleMessages() {
return false;
}
-void LayoutTestPushMessagingService::Unregister(
+void LayoutTestPushMessagingService::Unsubscribe(
const GURL& requesting_origin,
int64 service_worker_registration_id,
const std::string& sender_id,

Powered by Google App Engine
This is Rietveld 408576698