content/renderer/push_messaging/push_messaging_dispatcher.h - Issue 1134733006: Push API: use (un)subscription instead of (un)registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.h

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated patch set 2 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/push_messaging_service.h ('K') | « content/public/browser/push_messaging_service.cc ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/push_messaging/push_messaging_dispatcher.h

diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.h b/content/renderer/push_messaging/push_messaging_dispatcher.h

index 56eaa852820d80f6cf86ea18dc609a4a8ff9607b..032f6278820b2316e2593b7e11a03085dd157f59 100644

--- a/content/renderer/push_messaging/push_messaging_dispatcher.h

+++ b/content/renderer/push_messaging/push_messaging_dispatcher.h

@@ -50,11 +50,11 @@ class PushMessagingDispatcher : public RenderFrameObserver,

blink::WebPushSubscriptionCallbacks* callbacks,

const Manifest& manifest);

- void OnRegisterFromDocumentSuccess(int32_t request_id,

+ void OnSubscribeFromDocumentSuccess(int32_t request_id,

const GURL& endpoint,

Peter Beverloo 2015/05/18 12:44:37 nit: indentation +1

Pranay 2015/05/19 04:40:40 Done.

- const std::string& registration_id);

+ const std::string& subscription_id);

- void OnRegisterFromDocumentError(int32_t request_id,

+ void OnSubscribeFromDocumentError(int32_t request_id,

PushRegistrationStatus status);

Peter Beverloo 2015/05/18 12:44:37 nit: indentation +1

Pranay 2015/05/19 04:40:40 Done.

IDMap<blink::WebPushSubscriptionCallbacks, IDMapOwnPointer>