content/common/push_messaging_messages.h - Issue 1134733006: Push API: use (un)subscription instead of (un)registration

Unified Diff: content/common/push_messaging_messages.h

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated patch set 2 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/push_messaging/push_provider.cc ('K') | « content/child/push_messaging/push_provider.cc ('k') | content/public/browser/push_messaging_service.h » ('j') | content/public/browser/push_messaging_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/push_messaging_messages.h

diff --git a/content/common/push_messaging_messages.h b/content/common/push_messaging_messages.h

index dcf48b1b0d36590abf79f2e82e50529b2ab09f3c..872407b03a11f5ff2f565da5faad165677b214fb 100644

--- a/content/common/push_messaging_messages.h

+++ b/content/common/push_messaging_messages.h

@@ -31,29 +31,29 @@ IPC_ENUM_TRAITS_MAX_VALUE(

// Messages sent from the browser to the child process.

-IPC_MESSAGE_ROUTED3(PushMessagingMsg_RegisterFromDocumentSuccess,

+IPC_MESSAGE_ROUTED3(PushMessagingMsg_SubscribeFromDocumentSuccess,

int32_t /* request_id */,

GURL /* push_endpoint */,

std::string /* push_registration_id */)

Peter Beverloo 2015/05/18 12:44:37 push_registration_id -> push_subscription_id (else

Pranay 2015/05/19 04:40:40 Done.

-IPC_MESSAGE_CONTROL3(PushMessagingMsg_RegisterFromWorkerSuccess,

+IPC_MESSAGE_CONTROL3(PushMessagingMsg_SubscribeFromWorkerSuccess,

int32_t /* request_id */,

GURL /* push_endpoint */,

std::string /* push_registration_id */)

-IPC_MESSAGE_ROUTED2(PushMessagingMsg_RegisterFromDocumentError,

+IPC_MESSAGE_ROUTED2(PushMessagingMsg_SubscribeFromDocumentError,

int32_t /* request_id */,

content::PushRegistrationStatus /* status */)

-IPC_MESSAGE_CONTROL2(PushMessagingMsg_RegisterFromWorkerError,

+IPC_MESSAGE_CONTROL2(PushMessagingMsg_SubscribeFromWorkerError,

int32_t /* request_id */,

content::PushRegistrationStatus /* status */)

-IPC_MESSAGE_CONTROL2(PushMessagingMsg_UnregisterSuccess,

+IPC_MESSAGE_CONTROL2(PushMessagingMsg_UnsubscribeSuccess,

int32_t /* request_id */,

bool /* did_unregister */)

-IPC_MESSAGE_CONTROL3(PushMessagingMsg_UnregisterError,

+IPC_MESSAGE_CONTROL3(PushMessagingMsg_UnsubscribeError,

int32_t /* request_id */,

blink::WebPushError::ErrorType /* error_type */,

std::string /* error_message */)

@@ -77,19 +77,19 @@ IPC_MESSAGE_CONTROL2(PushMessagingMsg_GetPermissionStatusError,

// Messages sent from the child process to the browser.

-IPC_MESSAGE_CONTROL5(PushMessagingHostMsg_RegisterFromDocument,

+IPC_MESSAGE_CONTROL5(PushMessagingHostMsg_SubscribeFromDocument,

int32_t /* render_frame_id */,

int32_t /* request_id */,

std::string /* sender_id */,

bool /* user_visible */,

int64_t /* service_worker_registration_id */)

-IPC_MESSAGE_CONTROL3(PushMessagingHostMsg_RegisterFromWorker,

+IPC_MESSAGE_CONTROL3(PushMessagingHostMsg_SubscribeFromWorker,

int32_t /* request_id */,

int64_t /* service_worker_registration_id */,

bool /* user_visible */)

-IPC_MESSAGE_CONTROL2(PushMessagingHostMsg_Unregister,

+IPC_MESSAGE_CONTROL2(PushMessagingHostMsg_Unsubscribe,

int32_t /* request_id */,

int64_t /* service_worker_registration_id */)