content/browser/push_messaging/push_messaging_message_filter.h - Issue 1134733006: Push API: use (un)subscription instead of (un)registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.h

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Patch Set Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/push_messaging/push_messaging_service_impl.h ('K') | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/push_messaging/push_messaging_message_filter.h

diff --git a/content/browser/push_messaging/push_messaging_message_filter.h b/content/browser/push_messaging/push_messaging_message_filter.h

index afd8d6743a47550fb68984286bbc2955cd54fe11..e6247933aada5d177596f341574aa784ee736e66 100644

--- a/content/browser/push_messaging/push_messaging_message_filter.h

+++ b/content/browser/push_messaging/push_messaging_message_filter.h

@@ -45,15 +45,15 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {

void OnDestruct() const override;

bool OnMessageReceived(const IPC::Message& message) override;

- // Register methods on IO thread ---------------------------------------------

+ // Subscriube methods on IO thread ---------------------------------------------

- void OnRegisterFromDocument(int render_frame_id,

+ void OnSubscribeFromDocument(int render_frame_id,

int request_id,

const std::string& sender_id,

bool user_visible,

int64_t service_worker_registration_id);

- void OnRegisterFromWorker(int request_id,

+ void OnSubscribeFromWorker(int request_id,

int64_t service_worker_registration_id,

bool user_visible);

@@ -96,7 +96,7 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {

// Unregister methods on IO thread -------------------------------------------

- void OnUnregister(int request_id, int64_t service_worker_registration_id);

+ void OnUnsubscribe(int request_id, int64_t service_worker_registration_id);

void UnregisterHavingGottenPushRegistrationId(

int request_id,