content/shell/browser/layout_test/layout_test_push_messaging_service.h - Issue 1134733006: Push API: use (un)subscription instead of (un)registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.h

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed pre-submit warning Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/push_messaging/push_messaging_dispatcher.cc ('k') | content/shell/browser/layout_test/layout_test_push_messaging_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_push_messaging_service.h

diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.h b/content/shell/browser/layout_test/layout_test_push_messaging_service.h

index 2a472ec3280b32d4ed06093f36022e00cc4c53b1..35e50784e096d430d3f159fc12c9e9345aef9f30 100644

--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.h

+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.h

@@ -21,7 +21,7 @@ class LayoutTestPushMessagingService : public PushMessagingService {

// PushMessagingService implementation:

GURL GetPushEndpoint() override;

- void RegisterFromDocument(

+ void SubscribeFromDocument(

const GURL& requesting_origin,

int64 service_worker_registration_id,

const std::string& sender_id,

@@ -29,7 +29,7 @@ class LayoutTestPushMessagingService : public PushMessagingService {

int render_frame_id,

bool user_visible,

const PushMessagingService::RegisterCallback& callback) override;

- void RegisterFromWorker(

+ void SubscribeFromWorker(

const GURL& requesting_origin,

int64 service_worker_registration_id,

const std::string& sender_id,

@@ -40,10 +40,10 @@ class LayoutTestPushMessagingService : public PushMessagingService {

const GURL& embedding_origin,

bool user_visible) override;

bool SupportNonVisibleMessages() override;

- void Unregister(const GURL& requesting_origin,

- int64 service_worker_registration_id,

- const std::string& sender_id,

- const UnregisterCallback& callback) override;

+ void Unsubscribe(const GURL& requesting_origin,

+ int64 service_worker_registration_id,

+ const std::string& sender_id,

+ const UnregisterCallback& callback) override;

private:

DISALLOW_COPY_AND_ASSIGN(LayoutTestPushMessagingService);