Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1134733002: Enable copresencePrivate API in incognito mode (Closed)

Created:
5 years, 7 months ago by babu
Modified:
5 years, 7 months ago
Reviewers:
Charlie
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable copresencePrivate API in incognito mode This CL fixes a crash on opening chrome://copresence in incognito window. BUG=485992 Committed: https://crrev.com/d6e2fd12f9d16a6913f129dce5ebe7c5334c423a Cr-Commit-Position: refs/heads/master@{#329447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/extensions/api/copresence_private/copresence_private_api.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
babu
5 years, 7 months ago (2015-05-08 15:19:24 UTC) #2
Charlie
lgtm
5 years, 7 months ago (2015-05-12 17:30:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134733002/1
5 years, 7 months ago (2015-05-12 17:31:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 18:22:48 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 18:23:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6e2fd12f9d16a6913f129dce5ebe7c5334c423a
Cr-Commit-Position: refs/heads/master@{#329447}

Powered by Google App Engine
This is Rietveld 408576698