Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Issue 1134713003: Make Android Mojo Runner respect command line apps. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org, Ben Goodger (Google), jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Android Mojo Runner respect command line apps. Make Mandoline always run the mojo:window_manager. (afaik we don't want to specify other command line apps) Make Mojo Runner run the command line app (fallback on WM). (The Android impl wasn't respecting the command line app) Consolidate on Context::RunCommandLineApplication helper. BUG=486220 TEST=Android mojo shell and apptest runner can run non-WM apps (eg. apptests). R=sky@chromium.org Committed: https://crrev.com/1a4bbd1c973adbeeb9c9b4db061186a89fabbf0d Cr-Commit-Position: refs/heads/master@{#329970}

Patch Set 1 #

Patch Set 2 : Partial cleanup. #

Patch Set 3 : Copy desktop StartApp helper. Minor cleanup. #

Patch Set 4 : Consolidate code at Context::RunCommandLineApplication. #

Patch Set 5 : Simplify Mandoline LauncherProcessMain. #

Patch Set 6 : Sync and rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -38 lines) Patch
M mandoline/app/desktop/launcher_process.cc View 1 2 3 4 2 chunks +4 lines, -18 lines 0 comments Download
M mojo/runner/android/main.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M mojo/runner/context.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/runner/context.cc View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 1 2 3 2 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 7 months ago (2015-05-14 22:50:04 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-05-14 23:02:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134713003/100001
5 years, 7 months ago (2015-05-14 23:04:56 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-14 23:17:34 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 23:18:30 UTC) #7
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1a4bbd1c973adbeeb9c9b4db061186a89fabbf0d
Cr-Commit-Position: refs/heads/master@{#329970}

Powered by Google App Engine
This is Rietveld 408576698