Issue 11347053: ninja windows: emulate msvs generator behaviour for msvs_error_on_missing_sources=1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11347053: ninja windows: emulate msvs generator behaviour for msvs_error_on_missing_sources=1 (Closed)

Created:
8 years, 1 month ago by scottmg

Modified:
8 years, 1 month ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

ninja windows: emulate msvs generator behaviour for msvs_error_on_missing_sources=1 BUG=chromium:158651 Committed: https://code.google.com/p/gyp/source/detail?r=1527

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -23 lines)			Patch
M	pylib/gyp/generator/ninja.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pylib/gyp/msvs_emulation.py	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
M	test/msvs/missing_sources/gyptest-missing.py	View		1 chunk	+25 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm, thanks :-) https://codereview.chromium.org/11347053/diff/2002/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://codereview.chromium.org/11347053/diff/2002/pylib/gyp/msvs_emulation.py#newcode696 pylib/gyp/msvs_emulation.py:696: generator.""" nit 1: docstring could be ...

8 years, 1 month ago (2012-10-31 01:16:07 UTC) #2

scottmg

8 years, 1 month ago (2012-10-31 01:23:02 UTC) #3

https://codereview.chromium.org/11347053/diff/2002/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/11347053/diff/2002/pylib/gyp/msvs_emulation.p...
pylib/gyp/msvs_emulation.py:696: generator."""
On 2012/10/31 01:16:07, Nico wrote:
> nit 1: docstring could be more descriptive

Done.

> nit 2: i think it's behavior without a u ouver here

Done.

> nit 3: maybe it's sorces too, but not sure

https://www.google.com/search?q=sorces+locale%3Aen-US ... I'll file a bug about
"locale:" not working. ;)

Expand Messages | Collapse Messages

Issue 11347053: ninja windows: emulate msvs generator behaviour for msvs_error_on_missing_sources=1 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages