Chromium Code Reviews
Help | Chromium Project | Sign in
(24)

Issue 11347053: ninja windows: emulate msvs generator behaviour for msvs_error_on_missing_sources=1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by scottmg
Modified:
2 years, 4 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja windows: emulate msvs generator behaviour for msvs_error_on_missing_sources=1 BUG=chromium:158651 Committed: https://code.google.com/p/gyp/source/detail?r=1527

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -23 lines) Patch
M pylib/gyp/generator/ninja.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M test/msvs/missing_sources/gyptest-missing.py View 1 chunk +25 lines, -23 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
scottmg
2 years, 4 months ago (2012-10-31 00:52:37 UTC) #1
Nico
lgtm, thanks :-) https://codereview.chromium.org/11347053/diff/2002/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://codereview.chromium.org/11347053/diff/2002/pylib/gyp/msvs_emulation.py#newcode696 pylib/gyp/msvs_emulation.py:696: generator.""" nit 1: docstring could be ...
2 years, 4 months ago (2012-10-31 01:16:07 UTC) #2
scottmg
2 years, 4 months ago (2012-10-31 01:23:02 UTC) #3
https://codereview.chromium.org/11347053/diff/2002/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/11347053/diff/2002/pylib/gyp/msvs_emulation.p...
pylib/gyp/msvs_emulation.py:696: generator."""
On 2012/10/31 01:16:07, Nico wrote:
> nit 1: docstring could be more descriptive

Done.

> nit 2: i think it's behavior without a u ouver here

Done.

> nit 3: maybe it's sorces too, but not sure

https://www.google.com/search?q=sorces+locale%3Aen-US ... I'll file a bug about
"locale:" not working. ;)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted