Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart

Issue 11347035: isPrivate, isTopLevel moved to DeclarationMirror (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dartdoc/lib/mirrors.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
diff --git a/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart b/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
index ac92e29316c8dbdb5244ecfec76dcae0ba6a9144..f521fb63a14ed187869b84303a085840855b1544 100644
--- a/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
+++ b/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
@@ -387,19 +387,22 @@ abstract class Dart2JsMirror implements Mirror {
abstract class Dart2JsDeclarationMirror
implements Dart2JsMirror, DeclarationMirror {
+ bool get isTopLevel => owner != null && owner is LibraryMirror;
+
+ bool get isPrivate => _isPrivate(simpleName);
}
-abstract class Dart2JsMemberMirror
- implements Dart2JsDeclarationMirror, MemberMirror {
+abstract class Dart2JsMemberMirror extends Dart2JsDeclarationMirror
+ implements MemberMirror {
}
-abstract class Dart2JsTypeMirror
- implements Dart2JsDeclarationMirror, TypeMirror {
+abstract class Dart2JsTypeMirror extends Dart2JsDeclarationMirror
+ implements TypeMirror {
}
-abstract class Dart2JsElementMirror implements Dart2JsDeclarationMirror {
+abstract class Dart2JsElementMirror extends Dart2JsDeclarationMirror {
final Dart2JsMirrorSystem system;
final Element _element;
@@ -421,7 +424,7 @@ abstract class Dart2JsElementMirror implements Dart2JsDeclarationMirror {
int get hashCode => qualifiedName.hashCode;
}
-abstract class Dart2JsProxyMirror implements Dart2JsDeclarationMirror {
+abstract class Dart2JsProxyMirror extends Dart2JsDeclarationMirror {
final Dart2JsMirrorSystem system;
Dart2JsProxyMirror(this.system);
@@ -493,6 +496,8 @@ class Dart2JsLibraryMirror extends Dart2JsObjectMirror
DeclarationMirror get owner => null;
+ bool get isPrivate => false;
+
LibraryMirror library() => this;
/**
@@ -767,8 +772,6 @@ class Dart2JsClassMirror extends Dart2JsObjectMirror
bool get isAbstract => _class.modifiers.isAbstract();
- bool get isPrivate => _isPrivate(simpleName);
-
bool get isDeclaration => true;
List<TypeMirror> get typeArguments {
@@ -897,8 +900,6 @@ class Dart2JsTypedefMirror extends Dart2JsTypeElementMirror
bool get isInterface => false;
- bool get isPrivate => _isPrivate(simpleName);
-
bool get isDeclaration => true;
bool get isAbstract => false;
@@ -1388,8 +1389,6 @@ class Dart2JsFieldMirror extends Dart2JsElementMirror
bool get isMethod => false;
- bool get isPrivate => _isPrivate(simpleName);
-
bool get isStatic => _variable.modifiers.isStatic();
bool get isFinal => _variable.modifiers.isFinal();
« no previous file with comments | « pkg/dartdoc/lib/mirrors.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698