third_party/protobuf/README.chromium - Issue 11347026: Check in protobuf java code and generate lite jar.

Side by Side Diff: third_party/protobuf/README.chromium

Issue 11347026: Check in protobuf java code and generate lite jar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: Protocol Buffers	1 Name: Protocol Buffers

2 Short Name: protobuf	2 Short Name: protobuf

3 URL: http://protobuf.googlecode.com/svn/trunk	3 URL: http://protobuf.googlecode.com/svn/trunk

4 License: BSD	4 License: BSD

5 License File: COPYING.txt	5 License File: COPYING.txt

6 Version: unknown	6 Version: unknown

7 Revision: r423	7 Revision: r423

8 Security Critical: yes	8 Security Critical: yes

9	9

10 Local files (not taken from upstream):	10 Local files (not taken from upstream):

11 README.chromium	11 README.chromium

12 config.h	12 config.h

13 descriptor2_pb.py	13 descriptor2_pb.py

14	14

	15 The Java lite version of the library has been checked in directly under

	16 javalib/protobuf-java-2.4.1-lite.jar. It should be updated whenever a

	17 new version of protobuf is rolled. It can be built by following the

	18 instructions in svn/trunk/java/README.txt.

	19 Note: Remember to use the lite profile with "mvn install -P lite".
	Nico 2012/10/30 04:26:55 This makes it a lot harder to roll protobuf. This makes it a lot harder to roll protobuf. nyquist 2012/10/30 04:50:32 Agreed. Sadly, the protobuf library has external d Show quoted text On 2012/10/30 04:26:55, Nico wrote: > This makes it a lot harder to roll protobuf. Agreed. Sadly, the protobuf library has external dependencies such as JUnit and EasyMock. Those are test-tools though, so we might be able to do without them. If we check in the Java source we would have to keep the gyp/ant version of the build up to date based on updates from the maven pom.xml. Philippe 2012/10/30 08:59:28 I'm also concerned about making Protobuf rolls har Show quoted text On 2012/10/30 04:50:32, nyquist wrote: > On 2012/10/30 04:26:55, Nico wrote: > > This makes it a lot harder to roll protobuf. > > Agreed. Sadly, the protobuf library has external dependencies such as JUnit and > EasyMock. Those are test-tools though, so we might be able to do without them. > > If we check in the Java source we would have to keep the gyp/ant version of the > build up to date based on updates from the maven pom.xml. I'm also concerned about making Protobuf rolls harder. I think we could only have the JAR files of the dependencies which should not change too often (junit, easymock and others if needed) and trigger the Maven build of the Protobuf Java sources (using these JARs) from protobuf.gyp. In protobuf.gyp we would have a first step doing a 'mvn install' for each dependency JAR. On the downside, this means that Maven would be required for a Chromium for Android build (I think that's reasonable). We might want to check it into the tree too or better pull it through DEPS (on Android only) if possible. What do you think?
	20

15 A protobuf.gyp file has been added for building with Chromium.	21 A protobuf.gyp file has been added for building with Chromium.

16	22

17 This code has been patched to support unknown field retention in protobuf-lite.	23 This code has been patched to support unknown field retention in protobuf-lite.

18 See r62331 for the patch.	24 See r62331 for the patch.

19	25

20 Revision r427 was cherry-picked from upstream.	26 Revision r427 was cherry-picked from upstream.

21	27

22 Cherry-pick patch from http://code.google.com/p/protobuf/issues/detail?id=425.	28 Cherry-pick patch from http://code.google.com/p/protobuf/issues/detail?id=425.

OLD	NEW

« no previous file with comments | « no previous file | third_party/protobuf/javalib/protobuf-java-2.4.1-lite.jar » ('j') | no next file with comments »