Issue 11347012: Split IPC logging between content and chrome.

Issue 11347012: Split IPC logging between content and chrome. (Closed)

Created:
8 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
8 years, 1 month ago

Reviewers:
jam, Ben Goodger (Google), piman

CC:
chromium-reviews, joi+watch-content_chromium.org, tfarina, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split IPC logging between content and chrome. I add a new content API to register IPC message loggers, and modify the IPC message macros to not directly create the g_log_function_mapping. That allows for multiple files generating IPC loggers. Also, it gets rid of the ctor/dtor for the g_log_function_mapping. BUG=101600, 111316, 155765 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164861

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : ipclist #

Patch Set 4 : updates #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -38 lines)			Patch
M	chrome/browser/ui/views/about_ipc_dialog.cc	View		2 chunks	+3 lines, -10 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/common/DEPS	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/all_messages.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/logging_chrome.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	chrome/tools/ipclist/DEPS	View	1 2 3	1 chunk	+3 lines, -0 lines	2 comments	Download
M	chrome/tools/ipclist/ipcfuzz.cc	View	1 2	4 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/tools/ipclist/ipclist.cc	View	1 2	3 chunks	+3 lines, -1 line	0 comments	Download
A	content/common/all_messages.h	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
A	content/common/content_ipc_logging.cc	View	1 2	1 chunk	+37 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View		3 chunks	+3 lines, -0 lines	0 comments	Download
A	content/public/common/content_ipc_logging.h	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
M	content/shell/shell_main_delegate.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	ipc/ipc_message_macros.h	View		2 chunks	+4 lines, -14 lines	0 comments	Download
M	ppapi/proxy/plugin_main_nacl.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

plz review Antoine: ppapi/proxy ben: chrome/browser/ui/views John: rest

8 years, 1 month ago (2012-10-29 15:40:43 UTC) #1

jam

lgtm https://codereview.chromium.org/11347012/diff/2001/content/common/all_messages.h File content/common/all_messages.h (right): https://codereview.chromium.org/11347012/diff/2001/content/common/all_messages.h#newcode13 content/common/all_messages.h:13: // chrome/common/all_messages.h. nit: no need to mention chrome ...

8 years, 1 month ago (2012-10-29 15:48:48 UTC) #2

jochen (gone - plz use gerrit)

https://codereview.chromium.org/11347012/diff/9003/chrome/tools/ipclist/DEPS File chrome/tools/ipclist/DEPS (right): https://codereview.chromium.org/11347012/diff/9003/chrome/tools/ipclist/DEPS#newcode2 chrome/tools/ipclist/DEPS:2: "+content/common/all_messages.h", turns out the ipcfuzz/ipclist tools want to have ...

8 years, 1 month ago (2012-10-29 16:09:16 UTC) #3

jam

8 years, 1 month ago (2012-10-29 17:12:34 UTC) #6

https://codereview.chromium.org/11347012/diff/9003/chrome/tools/ipclist/DEPS
File chrome/tools/ipclist/DEPS (right):

https://codereview.chromium.org/11347012/diff/9003/chrome/tools/ipclist/DEPS#...
chrome/tools/ipclist/DEPS:2: "+content/common/all_messages.h",
On 2012/10/29 16:09:16, jochen wrote:
> turns out the ipcfuzz/ipclist tools want to have really all messages.
> 
> still looks good?

lgtm

Expand Messages | Collapse Messages