Issue 11347004: content/browser: Move speech code into content namespace.

Issue 11347004: content/browser: Move speech code into content namespace. (Closed)

Created:
8 years, 1 month ago by tfarina

Modified:
8 years, 1 month ago

Reviewers:
hans, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Satish, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

content/browser: Move speech code into content namespace. TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164625

Patch Set 7 : #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+271 lines, -343 lines)			Patch
M	content/browser/browser_main_loop.h	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/audio_buffer.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/audio_buffer.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/speech/audio_encoder.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/speech/audio_encoder.cc	View	1	5 chunks	+4 lines, -8 lines	0 comments	Download
M	content/browser/speech/chunked_byte_buffer.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/chunked_byte_buffer.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/chunked_byte_buffer_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/endpointer/endpointer.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/endpointer/endpointer.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/speech/endpointer/endpointer_unittest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/endpointer/energy_endpointer.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/endpointer/energy_endpointer.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/endpointer/energy_endpointer_params.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/endpointer/energy_endpointer_params.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/google_one_shot_remote_engine.h	View	1	2 chunks	+2 lines, -9 lines	0 comments	Download
M	content/browser/speech/google_one_shot_remote_engine.cc	View	1	6 chunks	+7 lines, -13 lines	0 comments	Download
M	content/browser/speech/google_one_shot_remote_engine_unittest.cc	View	1	5 chunks	+16 lines, -17 lines	0 comments	Download
M	content/browser/speech/google_streaming_remote_engine.h	View	1	3 chunks	+5 lines, -8 lines	0 comments	Download
M	content/browser/speech/google_streaming_remote_engine.cc	View	1	8 chunks	+17 lines, -24 lines	0 comments	Download
M	content/browser/speech/google_streaming_remote_engine_unittest.cc	View	1	10 chunks	+13 lines, -16 lines	0 comments	Download
M	content/browser/speech/input_tag_speech_dispatcher_host.h	View	1	3 chunks	+17 lines, -16 lines	0 comments	Download
M	content/browser/speech/input_tag_speech_dispatcher_host.cc	View	1	6 chunks	+9 lines, -12 lines	0 comments	Download
M	content/browser/speech/proto/google_streaming_api.proto	View	1 2 3 4 5	1 chunk	+1 line, -1 line	2 comments	Download
M	content/browser/speech/speech_recognition_browsertest.cc	View	1	10 chunks	+17 lines, -27 lines	0 comments	Download
M	content/browser/speech/speech_recognition_dispatcher_host.h	View	1	3 chunks	+17 lines, -16 lines	0 comments	Download
	content/browser/speech/speech_recognition_dispatcher_host.cc	View	1 2 3 4	8 chunks	+17 lines, -15 lines	0 comments	Download
M	content/browser/speech/speech_recognition_engine.h	View	1	4 chunks	+6 lines, -9 lines	0 comments	Download
M	content/browser/speech/speech_recognition_engine.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/speech_recognition_manager_impl.h	View	1	8 chunks	+18 lines, -21 lines	0 comments	Download
	content/browser/speech/speech_recognition_manager_impl.cc	View	1	8 chunks	+14 lines, -21 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.h	View	1 2 3 4	6 chunks	+15 lines, -17 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.cc	View	1	11 chunks	+16 lines, -30 lines	0 comments	Download
M	content/browser/speech/speech_recognizer_unittest.cc	View	1	21 chunks	+22 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11347004/7001

8 years, 1 month ago (2012-10-29 01:38:16 UTC) #2

jam

http://codereview.chromium.org/11347004/diff/7001/content/browser/speech/proto/google_streaming_api.proto File content/browser/speech/proto/google_streaming_api.proto (right): http://codereview.chromium.org/11347004/diff/7001/content/browser/speech/proto/google_streaming_api.proto#newcode11 content/browser/speech/proto/google_streaming_api.proto:11: package content.proto; i'm not familiar with proto files, so ...

8 years, 1 month ago (2012-10-29 03:05:21 UTC) #3

hans

8 years, 1 month ago (2012-10-29 11:29:29 UTC) #5

http://codereview.chromium.org/11347004/diff/7001/content/browser/speech/prot...
File content/browser/speech/proto/google_streaming_api.proto (right):

http://codereview.chromium.org/11347004/diff/7001/content/browser/speech/prot...
content/browser/speech/proto/google_streaming_api.proto:11: package
content.proto;
On 2012/10/29 03:05:21, John Abd-El-Malek wrote:
> i'm not familiar with proto files, so i don't know if anything else needs to
> change if this does. can you check with someone from the owners for this dir
who
> modified this file?

This looks fine. This has the effect of moving the generated
SpeechRecognitionEvent class from speech::proto to content::proto. The class is
used in google_streaming_remote_engine.cc and
google_streaming_remote_engine_unittest.cc, and I see that those are updated
correctly.

Expand Messages | Collapse Messages