Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1134683006: SkPDF: Add Sfntly to DEPS, gyp, SkUserConfig (Closed)

Created:
5 years, 7 months ago by hal.canary
Modified:
5 years, 7 months ago
Reviewers:
*mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Add Sfntly to DEPS, gyp Note: this can be disabled via: GYP_DEFINES='skia_pdf_use_sfntly=0 Warning: dm is 34% slower and uses 9% more memory. This is okay. Motivation: We want to test this code path in DM, since it is always used by Chromium and Android. BUG=skia:3563 Committed: https://skia.googlesource.com/skia/+/6a53b04e26749ea61f690ece408f2a1c0a5ad5bb Committed: https://skia.googlesource.com/skia/+/7be0ce0ab123bbad8ec22b67b8593f1bdd5179e0

Patch Set 1 #

Patch Set 2 : 2015-05-15 (Friday) 13:27:23 EDT #

Patch Set 3 : 2015-05-15 (Friday) 13:54:46 EDT #

Patch Set 4 : 2015-05-15 (Friday) 15:21:09 EDT #

Patch Set 5 : Sat May 16 20:59:11 EDT 2015 #

Patch Set 6 : 2015-05-18 (Monday) 10:51:28 EDT #

Patch Set 7 : 2015-05-18 (Monday) 11:20:53 EDT #

Patch Set 8 : 2015-05-18 (Monday) 13:33:42 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -4 lines) Patch
M DEPS View 1 1 chunk +5 lines, -0 lines 0 comments Download
A gyp/icu.gyp View 1 2 3 4 5 6 7 1 chunk +117 lines, -0 lines 0 comments Download
M gyp/pdf.gyp View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
A gyp/sfntly.gyp View 1 2 3 4 1 chunk +55 lines, -0 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 179 (101 generated)
hal.canary
PTAL
5 years, 7 months ago (2015-05-14 14:26:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/1
5 years, 7 months ago (2015-05-14 14:26:58 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1055) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 7 months ago (2015-05-14 14:28:52 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/20001
5 years, 7 months ago (2015-05-14 15:18:02 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/871) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 7 months ago (2015-05-14 15:20:01 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/40001
5 years, 7 months ago (2015-05-14 15:23:50 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/874) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 7 months ago (2015-05-14 15:25:51 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/60001
5 years, 7 months ago (2015-05-14 15:29:10 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/1068)
5 years, 7 months ago (2015-05-14 15:31:05 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/80001
5 years, 7 months ago (2015-05-14 15:56:19 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1062)
5 years, 7 months ago (2015-05-14 15:59:47 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/100001
5 years, 7 months ago (2015-05-14 16:46:24 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/1082)
5 years, 7 months ago (2015-05-14 16:48:51 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/120001
5 years, 7 months ago (2015-05-14 16:53:04 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/893) Build-Ubuntu-GCC-x86_64-Release-Trybot on ...
5 years, 7 months ago (2015-05-14 16:55:37 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/140001
5 years, 7 months ago (2015-05-14 16:57:30 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1067)
5 years, 7 months ago (2015-05-14 16:59:49 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/110008
5 years, 7 months ago (2015-05-14 17:29:45 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1071)
5 years, 7 months ago (2015-05-14 17:32:01 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/170001
5 years, 7 months ago (2015-05-14 17:34:37 UTC) #40
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/900) Build-Ubuntu-GCC-x86_64-Release-Trybot on ...
5 years, 7 months ago (2015-05-14 17:37:32 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/190001
5 years, 7 months ago (2015-05-14 17:41:15 UTC) #44
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-14 17:41:17 UTC) #45
commit-bot: I haz the power
Presubmit check for 1134683006-190001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 7 months ago (2015-05-14 17:41:32 UTC) #47
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/190001
5 years, 7 months ago (2015-05-14 17:44:21 UTC) #49
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/1092)
5 years, 7 months ago (2015-05-14 17:47:22 UTC) #51
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/210001
5 years, 7 months ago (2015-05-14 17:53:23 UTC) #53
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/1094)
5 years, 7 months ago (2015-05-14 17:56:06 UTC) #55
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/190002
5 years, 7 months ago (2015-05-14 18:00:25 UTC) #57
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/889) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 7 months ago (2015-05-14 18:02:30 UTC) #59
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/240001
5 years, 7 months ago (2015-05-14 18:26:57 UTC) #61
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1078)
5 years, 7 months ago (2015-05-14 18:28:44 UTC) #63
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/260001
5 years, 7 months ago (2015-05-14 18:30:29 UTC) #65
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/280001
5 years, 7 months ago (2015-05-14 18:32:41 UTC) #67
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1081)
5 years, 7 months ago (2015-05-14 18:34:09 UTC) #69
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/300001
5 years, 7 months ago (2015-05-14 18:39:09 UTC) #81
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/1091) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on ...
5 years, 7 months ago (2015-05-14 18:41:42 UTC) #83
reed1
maybe in a separate CL we should update SkPDFFont.cpp to be more guarded about when ...
5 years, 7 months ago (2015-05-14 18:46:07 UTC) #84
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/340001
5 years, 7 months ago (2015-05-14 18:54:49 UTC) #90
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/321)
5 years, 7 months ago (2015-05-14 18:57:03 UTC) #95
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/360001
5 years, 7 months ago (2015-05-14 19:26:02 UTC) #97
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/330008
5 years, 7 months ago (2015-05-15 14:51:45 UTC) #100
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/909)
5 years, 7 months ago (2015-05-15 14:53:15 UTC) #102
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/380001
5 years, 7 months ago (2015-05-15 14:54:25 UTC) #105
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/1109)
5 years, 7 months ago (2015-05-15 15:03:26 UTC) #107
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/420001
5 years, 7 months ago (2015-05-15 15:44:40 UTC) #109
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/3518)
5 years, 7 months ago (2015-05-15 15:59:52 UTC) #111
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/440001
5 years, 7 months ago (2015-05-15 17:28:50 UTC) #114
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 17:35:34 UTC) #120
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/460001
5 years, 7 months ago (2015-05-15 17:55:21 UTC) #122
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 18:01:30 UTC) #124
hal.canary
This seems to compile everywhere now. Shall I land?
5 years, 7 months ago (2015-05-15 18:10:39 UTC) #125
hal.canary
On 2015/05/14 18:46:07, reed1 wrote: > maybe in a separate CL we should update SkPDFFont.cpp ...
5 years, 7 months ago (2015-05-15 18:10:58 UTC) #126
reed1
lgtm
5 years, 7 months ago (2015-05-15 18:21:39 UTC) #127
reed1
what the heckity-heck? ICU is needed? crud.
5 years, 7 months ago (2015-05-15 18:22:25 UTC) #128
reed1
5 years, 7 months ago (2015-05-15 18:22:41 UTC) #130
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/480001
5 years, 7 months ago (2015-05-15 19:22:28 UTC) #133
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1096) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 7 months ago (2015-05-15 19:27:39 UTC) #135
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/500001
5 years, 7 months ago (2015-05-17 00:34:59 UTC) #138
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1113) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 7 months ago (2015-05-17 00:39:55 UTC) #140
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/520001
5 years, 7 months ago (2015-05-17 00:48:29 UTC) #144
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1115)
5 years, 7 months ago (2015-05-17 00:53:20 UTC) #146
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/450010
5 years, 7 months ago (2015-05-17 00:59:56 UTC) #150
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-17 01:05:59 UTC) #152
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/550001
5 years, 7 months ago (2015-05-18 14:52:15 UTC) #155
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 15:04:53 UTC) #157
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/570001
5 years, 7 months ago (2015-05-18 15:24:29 UTC) #160
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 15:30:57 UTC) #162
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/570001
5 years, 7 months ago (2015-05-18 15:35:17 UTC) #164
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
5 years, 7 months ago (2015-05-18 15:35:24 UTC) #166
hal.canary
Greatly simplified. Please take another look.
5 years, 7 months ago (2015-05-18 15:47:05 UTC) #167
mtklein
lgtm
5 years, 7 months ago (2015-05-18 17:18:21 UTC) #169
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/570001
5 years, 7 months ago (2015-05-18 17:18:40 UTC) #170
commit-bot: I haz the power
Committed patchset #7 (id:570001) as https://skia.googlesource.com/skia/+/6a53b04e26749ea61f690ece408f2a1c0a5ad5bb
5 years, 7 months ago (2015-05-18 17:19:07 UTC) #171
hal.canary
A revert of this CL (patchset #7 id:570001) has been created in https://codereview.chromium.org/1128353004/ by halcanary@google.com. ...
5 years, 7 months ago (2015-05-18 17:26:42 UTC) #172
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/590001
5 years, 7 months ago (2015-05-18 17:36:05 UTC) #175
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134683006/590001
5 years, 7 months ago (2015-05-18 17:42:01 UTC) #178
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 20:16:04 UTC) #179
Message was sent while issue was closed.
Committed patchset #8 (id:590001) as
https://skia.googlesource.com/skia/+/7be0ce0ab123bbad8ec22b67b8593f1bdd5179e0

Powered by Google App Engine
This is Rietveld 408576698