Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1134663006: [turbofan] Turn JSIntrinsicLowering into an AdvancedReducer. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_graph-reducer-advanced-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn JSIntrinsicLowering into an AdvancedReducer. This in turn allows usage of AdvancedReducer::ReplaceWithValue which has access to the underlying graph reducer. It will allow us to deal with exception continuations correctly. R=titzer@chromium.org Committed: https://crrev.com/c06b1e05ca4ef10a2c9136005bac9b40551d5b93 Cr-Commit-Position: refs/heads/master@{#28485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 13 chunks +17 lines, -17 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-18 16:45:54 UTC) #1
titzer
lgtm
5 years, 7 months ago (2015-05-18 17:35:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134663006/1
5 years, 7 months ago (2015-05-19 15:04:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 15:10:42 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 15:10:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c06b1e05ca4ef10a2c9136005bac9b40551d5b93
Cr-Commit-Position: refs/heads/master@{#28485}

Powered by Google App Engine
This is Rietveld 408576698