cc/layers/video_frame_provider.h - Issue 1134663005: cc: Video layers without a frame should not occlude

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/video_frame_provider.h

Issue 1134663005: cc: Video layers without a frame should not occlude (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add HasCurrentFrame Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/video_frame_provider.h

diff --git a/cc/layers/video_frame_provider.h b/cc/layers/video_frame_provider.h

index ff632f6546dea421dac7d7e9d6d2ddf07aa7711a..992cd1d5c6891afcc7de63b1cdfb542835f29de2 100644

--- a/cc/layers/video_frame_provider.h

+++ b/cc/layers/video_frame_provider.h

@@ -67,6 +67,8 @@ class CC_EXPORT VideoFrameProvider {

virtual bool UpdateCurrentFrame(base::TimeTicks deadline_min,

base::TimeTicks deadline_max) = 0;

+ virtual bool HasCurrentFrame() const = 0;

danakj 2015/05/18 18:15:45 can you comment what this is?

hendrikw 2015/05/18 18:33:59 Done.

// Returns the current frame, which may have been updated by a recent call to

// UpdateCurrentFrame(). A call to this method does not ensure that the frame

// will be rendered. A subsequent call to PutCurrentFrame() must be made if

« no previous file with comments | « no previous file | cc/layers/video_frame_provider_client_impl.h » ('j') | content/renderer/media/android/webmediaplayer_android.cc » ('J')