cc/resources/video_resource_updater.cc - Issue 1134643002: Add distinction between RGB and RGBA native texture video frames and resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/video_resource_updater.cc

Issue 1134643002: Add distinction between RGB and RGBA native texture video frames and resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/resources/video_resource_updater.h ('k') | cc/trees/layer_tree_host_unittest_context.cc » ('j') | content/renderer/media/android/webmediaplayer_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/resources/video_resource_updater.cc

diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc

index dea3176c43d65f9e59193049b459298e25c51f24..51dc819d3e82934942bdec3bdca092517510eb36 100644

--- a/cc/resources/video_resource_updater.cc

+++ b/cc/resources/video_resource_updater.cc

@@ -412,7 +412,10 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForHardwarePlanes(

VideoFrameExternalResources external_resources;

switch (mailbox_holder->texture_target) {

case GL_TEXTURE_2D:

- external_resources.type = VideoFrameExternalResources::RGB_RESOURCE;

+ if (video_frame->has_alpha())

+ external_resources.type = VideoFrameExternalResources::RGBA_RESOURCE;

+ else

+ external_resources.type = VideoFrameExternalResources::RGB_RESOURCE;

break;

case GL_TEXTURE_EXTERNAL_OES:

external_resources.type =