Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: runtime/vm/intrinsifier.cc

Issue 1134623004: - Use conditional code inclusion for the dart_no_snapshot and dart executables using the MACRO DART… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier.h ('k') | runtime/vm/method_recognizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier.cc
===================================================================
--- runtime/vm/intrinsifier.cc (revision 45699)
+++ runtime/vm/intrinsifier.cc (working copy)
@@ -34,6 +34,7 @@
}
+#if defined(DART_NO_SNAPSHOT)
void Intrinsifier::InitializeState() {
Isolate* isolate = Isolate::Current();
Library& lib = Library::Handle(isolate);
@@ -90,6 +91,7 @@
#undef SETUP_FUNCTION
}
+#endif // defined(DART_NO_SNAPSHOT).
static void EmitCodeFor(FlowGraphCompiler* compiler,
@@ -143,7 +145,6 @@
switch (function.recognized_kind()) {
#define EMIT_CASE(class_name, function_name, enum_name, fp) \
case MethodRecognizer::k##enum_name: \
- CHECK_FINGERPRINT3(function, class_name, function_name, enum_name, fp); \
if (!Build_##enum_name(graph)) return false; \
break;
@@ -187,26 +188,24 @@
#define EMIT_CASE(class_name, function_name, enum_name, fp) \
case MethodRecognizer::k##enum_name: \
- CHECK_FINGERPRINT3(function, class_name, function_name, enum_name, fp); \
compiler->assembler()->Comment("Intrinsic"); \
enum_name(compiler->assembler()); \
break;
- if (FLAG_throw_on_javascript_int_overflow && (Smi::kBits >= 32)) {
- // Integer intrinsics are in the core library, but we don't want to
- // intrinsify when Smi > 32 bits if we are looking for javascript integer
- // overflow.
+ switch (function.recognized_kind()) {
+ ALL_INTRINSICS_NO_INTEGER_LIB_LIST(EMIT_CASE);
+ default:
+ break;
+ }
+ // Integer intrinsics are in the core library, but we don't want to
+ // intrinsify when Smi > 32 bits if we are looking for javascript integer
+ // overflow.
+ if (!(FLAG_throw_on_javascript_int_overflow && (Smi::kBits >= 32))) {
switch (function.recognized_kind()) {
- ALL_INTRINSICS_NO_INTEGER_LIB_LIST(EMIT_CASE);
+ CORE_INTEGER_LIB_INTRINSIC_LIST(EMIT_CASE)
default:
break;
}
- } else {
- switch (function.recognized_kind()) {
- ALL_INTRINSICS_LIST(EMIT_CASE);
- default:
- break;
- }
}
#undef EMIT_INTRINSIC
}
« no previous file with comments | « runtime/vm/intrinsifier.h ('k') | runtime/vm/method_recognizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698