Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1134623003: GN: fixes for the official build. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, ddorwin
CC:
chromium-reviews, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: fixes for the official build. The C++ define OFFICIAL_BUILD wasn't getting set, and the widevine version .rc files was getting linked twice. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg R=dpranke TBR=ddorwin@chromium.org Committed: https://crrev.com/303920e6cd9d352e7a7b4e9bdcc2f28a30ac22fa Cr-Commit-Position: refs/heads/master@{#329308}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M build/config/BUILD.gn View 1 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
brettw
Dirk: everything. David: TBR owners review for widevine.
5 years, 7 months ago (2015-05-08 20:25:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134623003/1
5 years, 7 months ago (2015-05-08 20:28:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134623003/20001
5 years, 7 months ago (2015-05-08 22:59:14 UTC) #7
Dirk Pranke
lgtm. Please tell me this alone isn't the cause of 15MB of binary size increase ...
5 years, 7 months ago (2015-05-08 23:03:46 UTC) #8
brettw
No, this is random stuff I found when looking for missing things. It actually went ...
5 years, 7 months ago (2015-05-08 23:05:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134623003/20001
5 years, 7 months ago (2015-05-08 23:12:51 UTC) #12
ddorwin
third_party/widevine/ LGTM
5 years, 7 months ago (2015-05-09 01:13:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 03:13:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134623003/20001
5 years, 7 months ago (2015-05-09 06:31:30 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 12:15:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134623003/20001
5 years, 7 months ago (2015-05-12 00:04:47 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 02:01:18 UTC) #22
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:02:11 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/303920e6cd9d352e7a7b4e9bdcc2f28a30ac22fa
Cr-Commit-Position: refs/heads/master@{#329308}

Powered by Google App Engine
This is Rietveld 408576698